Add rollup config validation #69582
Merged
Add rollup config validation #69582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
>non-issue
:StorageEngine/Rollup
elasticmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
talevy
force-pushed
the
rollup-validate
branch
2 times, most recently
from
2659393 to
6a3e0c7
Compare
The RollupActionConfig objects had validation of mappings, but the TransportRollupAction never leveraged them to validate the action. This commit introduces a new first step for validation before continuing with the rollup.
talevy
force-pushed
the
rollup-validate
branch
from
6a3e0c7 to
1072248
Compare
Contributor
Author
|
run elasticsearch-ci/2 |
csoulios
approved these changes
Mar 5, 2021
Contributor
csoulios
left a comment
csoulios
left a comment
There was a problem hiding this comment.
LGTM. Thanks a lot Tal!
talevy
added a commit
to talevy/elasticsearch
that referenced
this pull request
Mar 8, 2021
The RollupActionConfig objects had validation of mappings, but the TransportRollupAction never leveraged them to validate the action. This commit introduces a new first step for validation before continuing with the rollup. validation exception messages had "... across all indices" removed from the messages of RollupAction objects, but legacy objects were left untouched since they still interact with index patterns and RollupAction is always against one index.
talevy
added a commit
that referenced
this pull request
Mar 8, 2021
The RollupActionConfig objects had validation of mappings, but the TransportRollupAction never leveraged them to validate the action. This commit introduces a new first step for validation before continuing with the rollup. validation exception messages had "... across all indices" removed from the messages of RollupAction objects, but legacy objects were left untouched since they still interact with index patterns and RollupAction is always against one index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RollupActionConfig objects had validation of mappings, but
the TransportRollupAction never leveraged them to validate the
action. This commit introduces a new first step for validation
before continuing with the rollup.
validation exception messages had "... across all indices" removed
from the messages of RollupAction objects, but legacy objects were
left untouched since they still interact with index patterns and
RollupAction is always against one index.