Make recovery APIs cancellable #69177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveCTurner
added
>enhancement
:Data Management/Stats
elasticmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
DaveCTurner
commented
Feb 18, 2021
| } | ||
|
|
||
| @Nullable // unless running tests that inject extra behaviour | ||
| private volatile Runnable onShardOperation; |
Contributor
Author
There was a problem hiding this comment.
This is totally stupid, but I just can't see a better way to block these operations for the purposes of this test.
original-brownbear
approved these changes
Feb 24, 2021
| /** | ||
| * Helper method for tests to call {@link TransportRecoveryAction#setOnShardOperation}. | ||
| */ | ||
| public static void setOnShardOperation(TransportRecoveryAction transportRecoveryAction, Runnable setOnShardOperation) { |
Contributor
There was a problem hiding this comment.
NIT: Maybe just inline this into the test class that actually uses it? Why have a separate method for this?
Contributor
Author
There was a problem hiding this comment.
I put it here so I could keep TransportRecoveryAction#setOnShardOperation package-private (without needing the test itself to be in the same package as the action)
Contributor
There was a problem hiding this comment.
ah ok, makes sense :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #55550