Deprecate GeoPolygon query in favour of GeoShape query. #64227
Conversation
iverase
added
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
elasticmachine
added
the
Team:Analytics
iverase
added
the
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
| } | ||
| } | ||
| -------------------------------------------------- | ||
| // TEST[warning:Deprecated field [geo_polygon] used, replaced by [[geo_shape] query where polygons are defined in geojson or wkt]] |
There was a problem hiding this comment.
@iverase Thanks Ignacio.
I would like to clarify something.
Is geo_polygon a different query from geo_shape?
Or is it the same query and it was just renamed from geo_polygon to geo_shape?
This warning looks like we just renamed the query. I thought we use this kind of warning when we rename a field. No?
There was a problem hiding this comment.
It is a different query that has the same functionality (and much more) than the geo_polygon query. I try to follow the same strategy as here: #42619.
There was a problem hiding this comment.
@iverase Thanks for the clarification, I was not aware that we use withAllDeprecated also with queries!
mayya-sharipova
left a comment
mayya-sharipova
left a comment
There was a problem hiding this comment.
@iverase Thanks, this LGTM.
One clarification, is geo_polygon query will be removed in v 8.x? Or we will still keep it in 8.x for Rest API version compatibility in case 7.x clients want to access it?
|
The plan is to keep it in 8.x and remove it in 9.0. |
5 participants
Following the development in #48928, GeoShape queries in more powerful that GeoPolygon queries and it makes little sense having both. This commit deprecates GeoPolygon queries.