Ensure assertion error is throw for tests in case of null license response #60573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywangd
added
>test
Collaborator
|
Pinging @elastic/es-security (:Security/License) |
Member
Author
|
@tvernum I just realised that #60498 will not work properly without converting ResponseException to AssertionError. I had it in one place but somehow missed for the other two. This PR addresses it. Sorry for the inconvenience. Sicne the backports have not been merged for #60498 yet. I am going to combine the backports into a single one for both this PR and #60498. |
tvernum
approved these changes
Aug 3, 2020
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Aug 3, 2020
…lastic#60573) This is a follow up for elastic#60498 to ensure an AssertionError is throw when the license is ready. The client throws a ResponseException for 404 status code. It needs to be converted to an AssertionError to correctly work with assertBusy.
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Aug 3, 2020
…lastic#60573) This is a follow up for elastic#60498 to ensure an AssertionError is throw when the license is ready. The client throws a ResponseException for 404 status code. It needs to be converted to an AssertionError to correctly work with assertBusy.
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Aug 3, 2020
…lastic#60573) This is a follow up for elastic#60498 to ensure an AssertionError is throw when the license is ready. The client throws a ResponseException for 404 status code. It needs to be converted to an AssertionError to correctly work with assertBusy.
This was referenced Aug 3, 2020
ywangd
added a commit
that referenced
this pull request
Aug 3, 2020
) When a new cluster starts, the HTTP layer becomes ready to accept incoming requests while the basic license is still being populated in the background. When a get license request comes in before the license is ready, it can get 404 error. This PR fixes it by either wrap the license check in assertBusy or ensure the license is ready before perform the check. This is a backport for both #60498 and #60573
ywangd
added a commit
that referenced
this pull request
Aug 3, 2020
) When a new cluster starts, the HTTP layer becomes ready to accept incoming requests while the basic license is still being populated in the background. When a get license request comes in before the license is ready, it can get 404 error. This PR fixes it by either wrap the license check in assertBusy or ensure the license is ready before perform the check. This is a backport for both #60498 and #60573
ywangd
added a commit
that referenced
this pull request
Aug 3, 2020
) When a new cluster starts, the HTTP layer becomes ready to accept incoming requests while the basic license is still being populated in the background. When a get license request comes in before the license is ready, it can get 404 error. This PR fixes it by either wrap the license check in assertBusy or ensure the license is ready before perform the check. This is a backport for both #60498 and #60573
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up for #60498 to ensure an AssertionError is throw when the license is ready.
The client throws a ResponseException for 404 status code. It needs to be converted to an AssertionError to correctly work with assertBusy.