-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Same memory when geo aggregations are not on top #57483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saves memory when the `geotile_grid` and `geohash_grid` are not on the top level by using the `LongKeyedBucketOrds` we built in elastic#55873.
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
16 tasks
Member
Author
|
I'd love to build a performance test for this one too! My desktop is busy as the moment though. |
talevy
approved these changes
Jun 1, 2020
Member
Author
|
Highlights: That is about 40% performance improvement in my test case. It looks like: |
Contributor
|
wow. look at that benchmark! 😮 🎈 |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jun 2, 2020
Saves memory when the `geotile_grid` and `geohash_grid` are not on the top level by using the `LongKeyedBucketOrds` we built in elastic#55873.
nik9000
added a commit
to nik9000/rally-tracks
that referenced
this pull request
Jun 2, 2020
Performance tests for elastic/elasticsearch#57483
nik9000
added a commit
that referenced
this pull request
Jun 2, 2020
hub-cap
pushed a commit
to elastic/rally-tracks
that referenced
this pull request
Jun 8, 2020
Performance tests for elastic/elasticsearch#57483
hub-cap
pushed a commit
to elastic/rally-tracks
that referenced
this pull request
Jun 9, 2020
Performance tests for elastic/elasticsearch#57483
hub-cap
pushed a commit
to elastic/rally-tracks
that referenced
this pull request
Jun 9, 2020
Performance tests for elastic/elasticsearch#57483
hub-cap
pushed a commit
to elastic/rally-tracks
that referenced
this pull request
Jun 9, 2020
Performance tests for elastic/elasticsearch#57483
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/Aggregations
Aggregations
backport
>enhancement
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
v7.9.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves memory when the
geotile_gridandgeohash_gridare not on thetop level by using the
LongKeyedBucketOrdswe built in #55873.