-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add Restore UUID Index Setting #56930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Restore UUID Index Setting #56930
Conversation
Pre-requesite for #50278 to be able to uniquely identify index metadata by its version fields and UUIDs when restoring into closed indices.
|
Pinging @elastic/es-distributed (:Distributed/Distributed) |
ywelsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should generalize this to an index.history.uuid (which is also updated on dangling indices import, as well as whenever we run the unsafe bootstrap command). This makes this also more generally useful to characterize the identity of the index metadata.
| settings.remove(IndexSettings.INDEX_SOFT_DELETES_SETTING.getKey()); | ||
| settings.remove(IndexMetadata.SETTING_INDEX_VERSION_CREATED.getKey()); | ||
| settings.remove(IndexMetadata.SETTING_INDEX_UUID); | ||
| settings.remove(IndexMetadata.SETTING_RESTORE_UUID); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove this setting on clone/split/shrink as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jup makes sense to me => done.
|
Jenkins run elasticsearch-ci/2 (random known aggs failure) |
|
Jenkins run elasticsearch-ci/bwc |
|
Thanks @ywelsch, I renamed the setting as suggested and added the functionality to dangling index import and unsafe bootstraps now. |
ywelsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks Yannick! |
Pre-requesite for #50278 to be able to uniquely identify index metadata by
its version fields and UUIDs when restoring into closed indices.
See related discussion here: #50278 (comment)