[ML] explicitly disallow partial results in datafeed extractors #55537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core (:ml) |
Member
Author
|
@elasticmachine update branch |
…results-in-datafeeds
przemekwitek
approved these changes
Apr 22, 2020
Contributor
przemekwitek
left a comment
przemekwitek
left a comment
There was a problem hiding this comment.
LGTM
Although I must admit I'm not very familiar with the mechanics of ScrollDataExtractor so you might want to consult someone else on changes to ScrollDataExtractor class.
hendrikmuhs
reviewed
Apr 22, 2020
hendrikmuhs
left a comment
hendrikmuhs
left a comment
There was a problem hiding this comment.
1 comment.
I also wonder if longer term it makes sense to look into SearchPhaseExcecutionException for root cause analysis and better reporting (we have some code for this ready).
.../elasticsearch/xpack/ml/datafeed/extractor/aggregation/AbstractAggregationDataExtractor.java
Outdated
Show resolved
Hide resolved
dimitris-athanasiou
approved these changes
Apr 22, 2020
Contributor
dimitris-athanasiou
left a comment
dimitris-athanasiou
left a comment
There was a problem hiding this comment.
LGTM Great stuff Ben!
…licitly-disallow-partial-results-in-datafeeds
benwtrent
deleted the
feature/ml-df-explicitly-disallow-partial-results-in-datafeeds
branch
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Apr 22, 2020
…tic#55537) Instead of doing our own checks against REST status, shard counts, and shard failures, this commit changes all our extractor search requests to set `.setAllowPartialSearchResults(false)`. - Scrolls are automatically cleared when a search failure occurs with `.setAllowPartialSearchResults(false)` set. - Code error handling is simplified closes elastic#40793
benwtrent
added a commit
that referenced
this pull request
Apr 22, 2020
…) (#55585) Instead of doing our own checks against REST status, shard counts, and shard failures, this commit changes all our extractor search requests to set `.setAllowPartialSearchResults(false)`. - Scrolls are automatically cleared when a search failure occurs with `.setAllowPartialSearchResults(false)` set. - Code error handling is simplified closes #40793
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing our own checks against REST status, shard counts, and shard failures, this commit changes all our extractor search requests to set
.setAllowPartialSearchResults(false)..setAllowPartialSearchResults(false)set.closes #40793