Move Watcher config out of RestResourcesPlugin #55136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelandis
added
:Delivery/Build
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
talevy
approved these changes
Apr 14, 2020
Contributor
talevy
left a comment
talevy
left a comment
There was a problem hiding this comment.
thanks for that Jake!
I'm glad where this turned out from our discussion.
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Apr 16, 2020
This commit moves Watcher out of the general purpose RestResourcesPlugin and declares the cross project test resource dependency explicitly. This (explicit dependencies) should be the general model for one-off cases such as this. The name of the x-pack configuration has also been updated to better match the non-x-pack variant. related elastic#53620
This was referenced Apr 16, 2020
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Apr 16, 2020
This commit moves Watcher out of the general purpose RestResourcesPlugin and declares the cross project test resource dependency explicitly. This (explicit dependencies) should be the general model for one-off cases such as this. The name of the x-pack configuration has also been updated to better match the non-x-pack variant. related elastic#53620
jakelandis
added a commit
that referenced
this pull request
Apr 17, 2020
jakelandis
added a commit
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves Watcher out of the general purpose RestResourcesPlugin
and declares the cross project test resource dependency explicitly.
This (explicit dependencies) should be the general model for one-off
cases such as this.
The name of the x-pack configuration has also been updated to better match
the non-x-pack variant.
related #53620