Skip to content

Only one of azure key or token can be specified in 3rd party tests #54876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tlrx merged 3 commits into from
Apr 7, 2020
Merged

Only one of azure key or token can be specified in 3rd party tests #54876

tlrx merged 3 commits into from
Apr 7, 2020

Conversation

@tlrx
Copy link
Member

@tlrx tlrx commented Apr 7, 2020

#54803 introduces more QA tests for Azure storage service, but they fail the build is one of the key or token is missing. It should instead work like repository-azure:qa tests.

@tlrx tlrx added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.0.0 v7.8.0 labels Apr 7, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 7, 2020

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

@tlrx tlrx requested a review from original-brownbear April 7, 2020 11:54
@tlrx
Copy link
Member Author

tlrx commented Apr 7, 2020

@elasticmachine run elasticsearch-ci/bwc
@elasticmachine run elasticsearch-ci/default-distro

@tlrx
Copy link
Member Author

tlrx commented Apr 7, 2020

@elasticmachine update branch

@tlrx
Copy link
Member Author

tlrx commented Apr 7, 2020

@elasticmachine run elasticsearch-ci/bwc

original-brownbear
original-brownbear approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@original-brownbear original-brownbear left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test failures seem unrelated

@original-brownbear
Copy link
Contributor

original-brownbear commented Apr 7, 2020

@elasticmachine run elasticsearch-ci/bwc

1 similar comment
@tlrx
Copy link
Member Author

tlrx commented Apr 7, 2020

@elasticmachine run elasticsearch-ci/bwc

@tlrx
Copy link
Member Author

tlrx commented Apr 7, 2020

@elasticmachine update branch

@tlrx tlrx merged commit 5283f15 into elastic:master Apr 7, 2020
@tlrx tlrx deleted the fix-azure-3rd-party-tests branch April 7, 2020 17:35
@tlrx
Copy link
Member Author

tlrx commented Apr 7, 2020

Thanks Armin!

tlrx added a commit that referenced this pull request Apr 7, 2020
@tlrx
Only one of azure key or token can be specified in 3rd party tests (#…
b8d2b95 
…54876)

#54803 introduces more QA tests for Azure storage service, but 
they fail the build is one of the key or token is missing. It should i
nstead work like repository-azure:qa tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@original-brownbear original-brownbear original-brownbear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test Issues or PRs that are addressing/adding tests v7.8.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tlrx @elasticmachine @original-brownbear @jakelandis