[ML] DF Analytics should always display operational stats #54210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit populates the _stats API response with sensible "empty" `data_counts` and `memory_usage` objects when the job itself has not started reporting them.
Collaborator
|
Pinging @elastic/ml-core (:ml) |
benwtrent
reviewed
Mar 25, 2020
Comment on lines
322
to
325
| Map<String, DataFrameAnalyticsConfig> configById = new HashMap<>(); | ||
| for (DataFrameAnalyticsConfig config : configs) { | ||
| configById.put(config.getId(), config); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| Map<String, DataFrameAnalyticsConfig> configById = new HashMap<>(); | |
| for (DataFrameAnalyticsConfig config : configs) { | |
| configById.put(config.getId(), config); | |
| } | |
| Map<String, DataFrameAnalyticsConfig> configById = configs.stream().collect(Collectors.toMap(DataFrameAnalyticsConfig::getId, Function.identity())); |
| statsItem.getState(), | ||
| statsItem.getFailureReason(), | ||
| statsItem.getProgress(), | ||
| statsItem.getDataCounts() == null ? new DataCounts(config.getId()) : statsItem.getDataCounts(), |
Member
There was a problem hiding this comment.
Why can't this and the memory usage be initialized in the stats ctor?
this.memoryUsage = memoryUsage == null ? new MemoryUsage(config.getId(), Instant.now(), 0) : memoryUsage;
this.dataCounts = dataCounts == null ? new DataCounts(config.getId()) : dataCounts;
Why do we need to set memory_usage create time to the config's create time? Is that adding value for the added complexity?
Or maybe I am misunderstanding the Stats#getId() value...
Contributor
Author
There was a problem hiding this comment.
I agree that's too much complexity for the gain. I'll make MemoryUsage.timestamp nullable.
client/rest-high-level/src/test/java/org/elasticsearch/client/MachineLearningIT.java
Outdated
Show resolved
Hide resolved
...k/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/stats/MemoryUsage.java
Show resolved
Hide resolved
...c/main/java/org/elasticsearch/xpack/ml/action/TransportGetDataFrameAnalyticsStatsAction.java
Show resolved
Hide resolved
benwtrent
approved these changes
Mar 26, 2020
Contributor
Author
|
@elasticmachine update branch |
dimitris-athanasiou
deleted the
df-analytics-always-display-operational-stats
branch
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Mar 26, 2020
…ic#54210) This commit populates the _stats API response with sensible "empty" `data_counts` and `memory_usage` objects when the job itself has not started reporting them. Backport of elastic#54210
dimitris-athanasiou
added a commit
that referenced
this pull request
Mar 26, 2020
dimitris-athanasiou
added a commit
that referenced
this pull request
Mar 26, 2020
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Mar 26, 2020
dimitris-athanasiou
added a commit
that referenced
this pull request
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit populates the _stats API response with sensible "empty"
data_countsandmemory_usageobjects when the job itselfhas not started reporting them.