[ML] relaxing parameters on stratified split test #54127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core (:ml) |
dimitris-athanasiou
approved these changes
Mar 24, 2020
Contributor
dimitris-athanasiou
left a comment
dimitris-athanasiou
left a comment
There was a problem hiding this comment.
LGTM Thanks for catching this Ben!
Member
|
This failed again today on CI (https://gradle-enterprise.elastic.co/s/m4pv2xig7k3nw):
@benwtrent It seems that this pull request will fix the failure. Can we get this merged? Thanks |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Mar 25, 2020
Relaxing the error rate a bit on two of the tests. Ran 1000s of times locally and never had a failure after these changes. closes elastic#54122
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Mar 25, 2020
Relaxing the error rate a bit on two of the tests. Ran 1000s of times locally and never had a failure after these changes. closes elastic#54122
benwtrent
added a commit
that referenced
this pull request
Mar 25, 2020
benwtrent
added a commit
that referenced
this pull request
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relaxing the error rate a bit on two of the tests.
Ran 1000s of times locally and never had a failure after these changes.
closes #54122