Wildcard field - add normalizer support #53851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markharwood
added
>enhancement
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search (:Search/Mapping) |
This was referenced Mar 20, 2020
jimczi
reviewed
Mar 20, 2020
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
I left one comment but adding the support for this option makes sense to me.
...ugin/wildcard/src/main/java/org/elasticsearch/xpack/wildcard/mapper/WildcardFieldMapper.java
Outdated
Show resolved
Hide resolved
markharwood
force-pushed
the
fix/53603norms
branch
from
594a545 to
2d3172c
Compare
jimczi
reviewed
Mar 23, 2020
...ugin/wildcard/src/main/java/org/elasticsearch/xpack/wildcard/mapper/WildcardFieldMapper.java
Outdated
Show resolved
Hide resolved
...ugin/wildcard/src/main/java/org/elasticsearch/xpack/wildcard/mapper/WildcardFieldMapper.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Good to go, @jimczi ? |
…erns and checkCompatibility
markharwood
force-pushed
the
fix/53603norms
branch
from
46439ec to
4f242fc
Compare
Contributor
Author
|
Backport to 7x pending on #53512 |
markharwood
added a commit
to markharwood/elasticsearch
that referenced
this pull request
Mar 24, 2020
* Add support for normalisation to wildcard field * Tidied imports * Added docs about params * Fix outdated error message * Avoid normaliser butchering wildcard query special characters * Fix broken test expectations * Fix wrong toString method * Address review comments - common method for normalising wildcard patterns and checkCompatibility * Remove unused import
markharwood
added a commit
that referenced
this pull request
Mar 24, 2020
markharwood
added a commit
to markharwood/elasticsearch
that referenced
this pull request
Mar 27, 2020
…tic#54109)" This reverts commit 6a60f85.
markharwood
added a commit
to markharwood/elasticsearch
that referenced
this pull request
Mar 27, 2020
…tic#54109)" This reverts commit 6a60f85.
markharwood
added a commit
that referenced
this pull request
Mar 27, 2020
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add normalizer support for the wildcard field to allow case insensitivity