Handle properly indexing rectangles that crosses the dateline #53810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>bug
:Analytics/Geo
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
Contributor
Author
|
@elasticmachine test this please |
imotov
approved these changes
Mar 20, 2020
Contributor
imotov
left a comment
imotov
left a comment
There was a problem hiding this comment.
Nice catch! Added a couple of minor requests. Otherwise LGTM.
server/src/main/java/org/elasticsearch/index/mapper/GeoShapeIndexer.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/search/geo/GeoShapeQueryTests.java
Show resolved
Hide resolved
iverase
added a commit
that referenced
this pull request
Mar 23, 2020
#53947) When indexing a rectangle that crosses the dateline, we are currently not handling it properly and we index a polygon that do not cross the dateline. This changes generates two polygons wrapping the dateline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When indexing a rectangle that crosses the dateline, we are currently not handling it properly and we index a polygon that do not cross the dateline. This changes generates two polygons wrapping the dateline.