Skip to content

Conversation

@jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Mar 6, 2020

The [word delimiter graph token filter docs][0] note that the trim
filter changes the length of tokens without changing their offsets.

This explicitly mentions that in the trim filter docs.

The [word delimiter graph token filter docs][0] note that the `trim`
filter changes the length of tokens without changing their offsets.

This explicitly mentions that in the `trim` filter docs.

[0]: https://www.elastic.co/guide/en/elasticsearch/reference/master/analysis-word-delimiter-graph-tokenfilter.html
@jrodewig jrodewig added >docs General docs changes :Search Relevance/Analysis How text is split into tokens labels Mar 6, 2020
@jrodewig jrodewig requested a review from romseygeek March 6, 2020 11:51
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Analysis)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jrodewig jrodewig merged commit 10f9a8f into elastic:master Mar 6, 2020
jrodewig added a commit that referenced this pull request Mar 6, 2020
The [word delimiter graph token filter docs][0] note that the `trim`
filter changes the length of tokens without changing their offsets.

This explicitly mentions that in the `trim` filter docs.

[0]: https://www.elastic.co/guide/en/elasticsearch/reference/master/analysis-word-delimiter-graph-tokenfilter.html
jrodewig added a commit that referenced this pull request Mar 6, 2020
The [word delimiter graph token filter docs][0] note that the `trim`
filter changes the length of tokens without changing their offsets.

This explicitly mentions that in the `trim` filter docs.

[0]: https://www.elastic.co/guide/en/elasticsearch/reference/master/analysis-word-delimiter-graph-tokenfilter.html
@jrodewig
Copy link
Contributor Author

jrodewig commented Mar 6, 2020

Backport commits

master 10f9a8f
7.x 9bb9f63
7.6 0990cac

@jrodewig jrodewig deleted the docs__note-trim-doesnt-change-offsets branch March 6, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes :Search Relevance/Analysis How text is split into tokens v7.6.2 v7.7.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants