Fix LoggingOutputStream to work on windows #51779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoggingOutputStream reads a stream and breaks on newlines. This commit fixes the behavior to account for windows newlines also containing `\r`. closes elastic#51532
rjernst
added
>bug
:Core/Infra/Logging
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Logging) |
mark-vieira
requested changes
Jan 31, 2020
server/src/main/java/org/elasticsearch/common/logging/LoggingOutputStream.java
Show resolved
Hide resolved
rjernst
added a commit
that referenced
this pull request
Feb 1, 2020
LoggingOutputStream reads a stream and breaks on newlines. This commit fixes the behavior to account for windows newlines also containing `\r`. closes #51532
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoggingOutputStream reads a stream and breaks on newlines. This commit
fixes the behavior to account for windows newlines also containing
\r.closes #51532