Skip to content

Use Lucene index in peer recovery and resync #51189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 20, 2020
Merged

Use Lucene index in peer recovery and resync #51189

merged 6 commits into from
Jan 20, 2020

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Jan 18, 2020

We can use Lucene index exclusively in peer recoveries and primary-replica resync in 8.0.

Relates #50775

@dnhatn dnhatn added >enhancement :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. v8.0.0 labels Jan 18, 2020
@dnhatn dnhatn requested a review from ywelsch January 18, 2020 20:48
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 18, 2020

Pinging @elastic/es-distributed (:Distributed/Recovery)

@dnhatn dnhatn mentioned this pull request Jan 18, 2020
Closed
14 tasks
ywelsch
ywelsch reviewed Jan 20, 2020
View reviewed changes
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left one comment, looking good o.w.

@dnhatn dnhatn requested a review from ywelsch January 20, 2020 15:45
ywelsch
ywelsch approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Jan 20, 2020

Thanks Yannick

@dnhatn dnhatn merged commit 6e2f7b4 into elastic:master Jan 20, 2020
@dnhatn dnhatn deleted the use-soft-deletes-recovery branch January 20, 2020 22:06
@williamrandolph williamrandolph mentioned this pull request Jan 21, 2020
Closed
@dnhatn dnhatn mentioned this pull request Jan 23, 2020
Merged
dnhatn added a commit that referenced this pull request Jan 24, 2020
@dnhatn
Enable operation-based recoveries for old copies (#51380)
80cacc6 
We accidentally disabled operation-based recoveries for 
indices with soft-deletes created before 7.6 in #51189.

Relates #51189
Closes #51274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ywelsch ywelsch ywelsch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. >enhancement v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dnhatn @elasticmachine @ywelsch @jakelandis