-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[DOCS] Reformat compound word token filters #49006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Reformat compound word token filters #49006
Conversation
|
Pinging @elastic/es-search (:Search/Analysis) |
|
Pinging @elastic/es-docs (>docs) |
* Separates the compound token filters doc pages into separate token filter pages: ** Dictionary decompounder token filter ** Hyphenation decompounder token filter * Adds analyze API examples for each compound token filter * Adds a redirect for the removed compound token filters page
debadair
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor suggestions. I think for reference items, splitting them apart is better for discoverability.
docs/reference/analysis/tokenfilters/dictionary-decompounder-tokenfilter.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/analysis/tokenfilters/dictionary-decompounder-tokenfilter.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/analysis/tokenfilters/dictionary-decompounder-tokenfilter.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/analysis/tokenfilters/dictionary-decompounder-tokenfilter.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/analysis/tokenfilters/dictionary-decompounder-tokenfilter.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/analysis/tokenfilters/hyphenation-decompounder-tokenfilter.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/analysis/tokenfilters/hyphenation-decompounder-tokenfilter.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/analysis/tokenfilters/hyphenation-decompounder-tokenfilter.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/analysis/tokenfilters/hyphenation-decompounder-tokenfilter.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/analysis/tokenfilters/hyphenation-decompounder-tokenfilter.asciidoc
Outdated
Show resolved
Hide resolved
romseygeek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…okenfilter.asciidoc Co-Authored-By: debadair <[email protected]>
…okenfilter.asciidoc Co-Authored-By: debadair <[email protected]>
…okenfilter.asciidoc Co-Authored-By: debadair <[email protected]>
…okenfilter.asciidoc Co-Authored-By: debadair <[email protected]>
…tokenfilter.asciidoc Co-Authored-By: debadair <[email protected]>
…tokenfilter.asciidoc Co-Authored-By: debadair <[email protected]>
…tokenfilter.asciidoc Co-Authored-By: debadair <[email protected]>
…tokenfilter.asciidoc Co-Authored-By: debadair <[email protected]>
…okenfilter.asciidoc Co-Authored-By: debadair <[email protected]>
|
@elasticmachine update branch |
* Separates the compound token filters doc pages into separate token filter pages: * Dictionary decompounder token filter * Hyphenation decompounder token filter * Adds analyze API examples for each compound token filter * Adds a redirect for the removed compound token filters page Co-Authored-By: debadair <[email protected]>
* Separates the compound token filters doc pages into separate token filter pages: * Dictionary decompounder token filter * Hyphenation decompounder token filter * Adds analyze API examples for each compound token filter * Adds a redirect for the removed compound token filters page Co-Authored-By: debadair <[email protected]>
* Separates the compound token filters doc pages into separate token filter pages: * Dictionary decompounder token filter * Hyphenation decompounder token filter * Adds analyze API examples for each compound token filter * Adds a redirect for the removed compound token filters page Co-Authored-By: debadair <[email protected]>
Reformats the compound token filters docs as part of #44726.
I also decided to separate the token filter docs as part of this PR. However, I don't feel strongly about it. If we prefer to keep these token filter docs on the same page, I can do that.
Changes
Separates the compound token filters doc pages into separate token
filter pages:
Adds analyze API examples for each compound token filter
Adds a redirect for the removed compound token filters page