Skip to content

Conversation

@jrodewig
Copy link
Contributor

Reformats the compound token filters docs as part of #44726.

I also decided to separate the token filter docs as part of this PR. However, I don't feel strongly about it. If we prefer to keep these token filter docs on the same page, I can do that.

Changes

  • Separates the compound token filters doc pages into separate token
    filter pages:

    • Dictionary decompounder token filter
    • Hyphenation decompounder token filter
  • Adds analyze API examples for each compound token filter

  • Adds a redirect for the removed compound token filters page

@jrodewig jrodewig added >docs General docs changes :Search Relevance/Analysis How text is split into tokens v8.0.0 v7.5.0 v7.6.0 v7.4.3 labels Nov 12, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Analysis)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

* Separates the compound token filters doc pages into separate token
  filter pages:
  ** Dictionary decompounder token filter
  ** Hyphenation decompounder token filter

* Adds analyze API examples for each compound token filter

* Adds a redirect for the removed compound token filters page
Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor suggestions. I think for reference items, splitting them apart is better for discoverability.

Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig
Copy link
Contributor Author

@elasticmachine update branch

@jrodewig jrodewig merged commit c4e113e into elastic:master Nov 13, 2019
@jrodewig jrodewig deleted the reformat.compound-word-filters branch November 13, 2019 14:35
jrodewig added a commit that referenced this pull request Nov 13, 2019
* Separates the compound token filters doc pages into separate token
  filter pages:
  * Dictionary decompounder token filter
  * Hyphenation decompounder token filter

* Adds analyze API examples for each compound token filter

* Adds a redirect for the removed compound token filters page

Co-Authored-By: debadair <[email protected]>
jrodewig added a commit that referenced this pull request Nov 13, 2019
* Separates the compound token filters doc pages into separate token
  filter pages:
  * Dictionary decompounder token filter
  * Hyphenation decompounder token filter

* Adds analyze API examples for each compound token filter

* Adds a redirect for the removed compound token filters page

Co-Authored-By: debadair <[email protected]>
jrodewig added a commit that referenced this pull request Nov 13, 2019
* Separates the compound token filters doc pages into separate token
  filter pages:
  * Dictionary decompounder token filter
  * Hyphenation decompounder token filter

* Adds analyze API examples for each compound token filter

* Adds a redirect for the removed compound token filters page

Co-Authored-By: debadair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants