Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Edited Docker install & tweaked Docker compose file. #47715

Merged
merged 12 commits into from
Nov 1, 2019

Conversation

debadair
Copy link
Contributor

@debadair debadair commented Oct 8, 2019

Cleaned up the docker install instructions to remove the implication that a two-node cluster is recommended for productions.

Relates to elastic/stack-docs#455

@debadair debadair added >docs General docs changes :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts WIP v8.0.0 7x v7.4.0 labels Oct 8, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Packaging)

@colings86 colings86 removed the 7x label Oct 8, 2019
@rjernst
Copy link
Member

rjernst commented Oct 10, 2019

@pugnascotia Would you please review this?

Long term it would be great if we could not have the docker compose file embedded in the docs source files, but instead have files that the docs build inserts when building, similar to what we have with some java source files used for examples. This way we can test the exact yml file we are suggesting users use.

Copy link
Contributor

@pugnascotia pugnascotia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying out the actual compose file, and I'm having trouble getting it work. I'll keep digging.

@pugnascotia
Copy link
Contributor

OK, I figured it out - I was struggling to use the docker-compose.yml setup in Docker for Mac, because I needed to increase the amount of memory available to the Docker Engine. Once I increased it from 2GB to 4GB, everything worked. It might be worth adding a note to the docs about this, since the symptoms I experienced were simply that some of the containers would just exit, without anything in the Docker logs.

After fixing the issue via guesswork, I dug further. The containers were exiting with code 137, which according to a help article from Docker, corresponds to 128 + 9 => 137, in order words a kill -9. By using screen to get into the VM, as per the docs, and running dmesg, I was able to confirm that the the containers were being killed for running out of memory.

@pugnascotia
Copy link
Contributor

Re: elastic/stack-docs#455, are we going to update the example docker-compose.yml file further to enable security?

@debadair
Copy link
Contributor Author

Thanks for the review @pugnascotia! I synced with the changes to elastic/stack-docs#455 and incorporated your feedback. That PR now has the TLS version, as well.

The goal is indeed to have the sample compose files separate, testable entities. They're separate files now, will work on the testing part once these PRs are merged.

@debadair debadair removed the WIP label Oct 29, 2019
@pugnascotia
Copy link
Contributor

@debadair can we incorporate up the docker-compose.yml changes in https://github.com/elastic/elasticsearch/pull/47650/files too please?

@pugnascotia
Copy link
Contributor

Revisions look good 👍

@debadair
Copy link
Contributor Author

debadair commented Nov 1, 2019

@elasticmachine run docs build

@debadair
Copy link
Contributor Author

debadair commented Nov 1, 2019

@elasticmachine, run elasticsearch-ci/docs

@debadair debadair merged commit 2f9f576 into elastic:master Nov 1, 2019
debadair added a commit that referenced this pull request Nov 1, 2019
* [DOCS] Edited Docker install & tweaked Docker compose file.

* Synced with Docker GS in SO

* Incorporated review comments
debadair added a commit that referenced this pull request Nov 1, 2019
* [DOCS] Edited Docker install & tweaked Docker compose file.

* Synced with Docker GS in SO

* Incorporated review comments
debadair added a commit that referenced this pull request Nov 1, 2019
* [DOCS] Edited Docker install & tweaked Docker compose file.

* Synced with Docker GS in SO

* Incorporated review comments
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >docs General docs changes Team:Delivery Meta label for Delivery team v7.4.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants