-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Edited Docker install & tweaked Docker compose file. #47715
Conversation
Pinging @elastic/es-docs (>docs) |
Pinging @elastic/es-core-infra (:Core/Infra/Packaging) |
@pugnascotia Would you please review this? Long term it would be great if we could not have the docker compose file embedded in the docs source files, but instead have files that the docs build inserts when building, similar to what we have with some java source files used for examples. This way we can test the exact yml file we are suggesting users use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying out the actual compose file, and I'm having trouble getting it work. I'll keep digging.
OK, I figured it out - I was struggling to use the After fixing the issue via guesswork, I dug further. The containers were exiting with code 137, which according to a help article from Docker, corresponds to 128 + 9 => 137, in order words a |
Re: elastic/stack-docs#455, are we going to update the example |
Thanks for the review @pugnascotia! I synced with the changes to elastic/stack-docs#455 and incorporated your feedback. That PR now has the TLS version, as well. The goal is indeed to have the sample compose files separate, testable entities. They're separate files now, will work on the testing part once these PRs are merged. |
@debadair can we incorporate up the |
Revisions look good 👍 |
@elasticmachine run docs build |
@elasticmachine, run elasticsearch-ci/docs |
* [DOCS] Edited Docker install & tweaked Docker compose file. * Synced with Docker GS in SO * Incorporated review comments
* [DOCS] Edited Docker install & tweaked Docker compose file. * Synced with Docker GS in SO * Incorporated review comments
* [DOCS] Edited Docker install & tweaked Docker compose file. * Synced with Docker GS in SO * Incorporated review comments
Cleaned up the docker install instructions to remove the implication that a two-node cluster is recommended for productions.
Relates to elastic/stack-docs#455