Skip to content

Conversation

@astefan
Copy link
Contributor

@astefan astefan commented Jul 24, 2019

Following #41557, this PR re-enables JdbcConfigurationTests.testDriverConfigurationWithSSLInURL with more logging coming from the DriverManager hopefully getting more insight for the next time this test fails.

additional logging from the DriverManager.
@astefan astefan added the :Analytics/SQL SQL querying label Jul 24, 2019
@astefan astefan requested a review from matriv July 24, 2019 10:09
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@astefan
Copy link
Contributor Author

astefan commented Jul 24, 2019

@elasticmachine run elasticsearch-ci/packaging-sample

@astefan
Copy link
Contributor Author

astefan commented Jul 24, 2019

@elasticmachine run elasticsearch-ci/2

@matriv matriv added the >test Issues or PRs that are addressing/adding tests label Jul 24, 2019
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/41557")
public void testDriverConfigurationWithSSLInURL() {
@SuppressForbidden(reason = "JDBC drivers allows logging to Sys.out")
public void testDriverConfigurationWithSSLInURL() throws Exception {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think throws Exception is not necessary.

@matriv matriv changed the title SQL: Re-enable testDriverConfigurationWithSSLInURL test with more logging SQL: [Tests] Re-enable testDriverConfigurationWithSSLInURL test with more logging Jul 24, 2019
@astefan astefan merged commit 5b9ccd7 into elastic:master Jul 25, 2019
astefan added a commit that referenced this pull request Jul 25, 2019
astefan added a commit that referenced this pull request Jul 25, 2019
astefan added a commit that referenced this pull request Jul 25, 2019
astefan added a commit that referenced this pull request Jul 25, 2019
astefan added a commit that referenced this pull request Jul 25, 2019
@astefan astefan deleted the enable_jdbc_driver_ssl_test branch October 16, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/SQL SQL querying >test Issues or PRs that are addressing/adding tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants