-
Notifications
You must be signed in to change notification settings - Fork 25.7k
SQL: [Tests] Re-enable testDriverConfigurationWithSSLInURL test with more logging #44800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
additional logging from the DriverManager.
|
Pinging @elastic/es-search |
|
@elasticmachine run elasticsearch-ci/packaging-sample |
|
@elasticmachine run elasticsearch-ci/2 |
matriv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| @AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/41557") | ||
| public void testDriverConfigurationWithSSLInURL() { | ||
| @SuppressForbidden(reason = "JDBC drivers allows logging to Sys.out") | ||
| public void testDriverConfigurationWithSSLInURL() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think throws Exception is not necessary.
…o enable_jdbc_driver_ssl_test
Following #41557, this PR re-enables
JdbcConfigurationTests.testDriverConfigurationWithSSLInURLwith more logging coming from the DriverManager hopefully getting more insight for the next time this test fails.