From 20bf3427f108129b4808cd79c46aee254bc0804a Mon Sep 17 00:00:00 2001 From: Ryan Ernst Date: Thu, 20 Jun 2019 13:07:54 -0700 Subject: [PATCH 1/2] Clarify unsupported secure settings behavior This commit tweaks the docs for secure settings to ensure the user is aware adding non secure settings to the keystore will result in elasticsearch not starting. fixes #43328 --- docs/reference/setup/secure-settings.asciidoc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/docs/reference/setup/secure-settings.asciidoc b/docs/reference/setup/secure-settings.asciidoc index 4e3799db75bde..3a8e7b2dab901 100644 --- a/docs/reference/setup/secure-settings.asciidoc +++ b/docs/reference/setup/secure-settings.asciidoc @@ -7,8 +7,11 @@ keystore and the `elasticsearch-keystore` tool to manage the settings in the key NOTE: All commands here should be run as the user which will run Elasticsearch. -NOTE: Only some settings are designed to be read from the keystore. See -documentation for each setting to see if it is supported as part of the keystore. +IMPORTANT: Only some settings are designed to be read from the keystore. However, +the keystore currently has no validation to block adding settings not supported. +Additional unsupported settings being added to the keystore will cause Elasticsearch +to fail to start. See documentation for each setting to see if it is supported +as part of the keystore. NOTE: All the modifications to the keystore take affect only after restarting Elasticsearch. From 60ae55906367cecf29f27419169700c062179fb2 Mon Sep 17 00:00:00 2001 From: Ryan Ernst Date: Thu, 20 Jun 2019 14:12:15 -0700 Subject: [PATCH 2/2] Update docs/reference/setup/secure-settings.asciidoc Co-Authored-By: James Rodewig --- docs/reference/setup/secure-settings.asciidoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/reference/setup/secure-settings.asciidoc b/docs/reference/setup/secure-settings.asciidoc index 3a8e7b2dab901..82b61848a846d 100644 --- a/docs/reference/setup/secure-settings.asciidoc +++ b/docs/reference/setup/secure-settings.asciidoc @@ -8,7 +8,8 @@ keystore and the `elasticsearch-keystore` tool to manage the settings in the key NOTE: All commands here should be run as the user which will run Elasticsearch. IMPORTANT: Only some settings are designed to be read from the keystore. However, -the keystore currently has no validation to block adding settings not supported. +the keystore has no validation to block unsupported settings. +Adding unsupported settings to the keystore will cause {es} Additional unsupported settings being added to the keystore will cause Elasticsearch to fail to start. See documentation for each setting to see if it is supported as part of the keystore.