Skip to content

Describing the latest version #40355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2019
Merged

Describing the latest version #40355

merged 1 commit into from
Mar 29, 2019

Conversation

@omkar-dsd
Copy link
Contributor

@omkar-dsd omkar-dsd commented Mar 22, 2019 •
edited
Loading

The doc maintain examples by giving two examples for each procedure, one example for the older version (2.x) and the other for the latest version. Making the correction as now the latest major version is 6.

@polyfractal polyfractal added the >docs General docs changes label Mar 22, 2019
@polyfractal
Copy link
Contributor

polyfractal commented Mar 22, 2019

Thanks! Would you mind Signing the CLA so that we can merge this?

@honzakral mind reviewing this since it's regarding the python client? I assume it's fine but wanted to double check :)

@polyfractal polyfractal requested a review from honzakral March 22, 2019 14:20
@omkar-dsd
Copy link
Contributor Author

omkar-dsd commented Mar 23, 2019 •
edited
Loading

@polyfractal I have signed :). I have seen many outdated docs. If it's fine, I can go ahead and update all of them

honzakral
honzakral approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@honzakral honzakral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch, @omkar-dsd, that is exactly what it should say, much appreciated!

@polyfractal
Copy link
Contributor

polyfractal commented Mar 28, 2019

@elasticmachine test this please

@polyfractal polyfractal merged commit 237a2c4 into elastic:master Mar 29, 2019
polyfractal pushed a commit that referenced this pull request Apr 2, 2019
@omkar-dsd @polyfractal
Update version numbers in Elasticsearch-Py docs (#40355)
ee8382d
polyfractal pushed a commit that referenced this pull request Apr 2, 2019
@omkar-dsd @polyfractal
Update version numbers in Elasticsearch-Py docs (#40355)
4ed591a
@polyfractal
Copy link
Contributor

polyfractal commented Apr 3, 2019

Backport pending for 6.7, added label

@omkar-dsd
Copy link
Contributor Author

omkar-dsd commented Apr 4, 2019

What needs to be done for the Backport Pending label?

@polyfractal
Copy link
Contributor

polyfractal commented Apr 4, 2019

Nothing needs doing on your end, sorry for the confusion. The 6.7 branch was temporarily frozen to all commits to facilitate a release, so I couldn't merge this into that branch. The backport pending label was added so I wouldn't forget to merge once the branch was unfrozen.

I believe it just unfroze, so I'll get this backported shortly :)

polyfractal pushed a commit that referenced this pull request Apr 24, 2019
@omkar-dsd @polyfractal
Update version numbers in Elasticsearch-Py docs (#40355)
3e60785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@honzakral honzakral honzakral approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

>docs General docs changes v6.7.1 v7.0.0-rc2 v7.2.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@omkar-dsd @polyfractal @honzakral @jakelandis