[Zen2] Minor logging improvements #36818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds term number and greppable phrase 'coordinator becoming' to Coordinator mode changes * Adds term and version to messages from the ClusterApplier about master changes * Reduces some LeaderChecker messages to TRACE level
DaveCTurner
added
>non-issue
v7.0.0
:Distributed Coordination/Cluster Coordination
Collaborator
|
Pinging @elastic/es-distributed |
ywelsch
approved these changes
Dec 19, 2018
| String summary = nodesDelta.shortSummary(); | ||
| if (summary.length() > 0) { | ||
| logger.info("{}, reason: {}", summary, task.source); | ||
| logger.info("{}, term: {}, version: {}, reason: {}", |
Contributor
There was a problem hiding this comment.
should we update the same message in MasterService?
Contributor
Author
There was a problem hiding this comment.
I think the ClusterApplierService one is more useful since it logs on all nodes and also when adding a no-master block, but it could be useful in the MasterService too so I pushed a02075d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"coordinator becoming"toCoordinatormode changesClusterApplierandMasterServiceabout changes toDiscoveryNodes, including if the currentmaster changes.
LeaderCheckermessages toTRACElevel