[DOCS] Adds new dynamic machine learning settings #34094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core |
Contributor
Author
|
@droberts195 and @benwtrent: One thing that wasn't clear to me was whether the percentage of date/order errors is relative to a subset of the data (e.g. per bucket). If we can clarify that in the description, that'd be great. |
droberts195
reviewed
Sep 28, 2018
| The maximum number of records that are output per bucket. The default value is | ||
| `500`. | ||
|
|
||
| `xpack.ml.max_percent_date_errors`:: (<<cluster-update-settings,Dynamic>>) |
There was a problem hiding this comment.
It turns out that this setting and xpack.ml.max_percent_out_of_order_errors are never used anywhere. (They used to be used in the old Prelert product.)
So they should be removed completely from the docs and code.
Contributor
Author
|
Thanks @droberts195, I've removed those two settings. |
lcawl
added a commit
that referenced
this pull request
Sep 28, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #33961 and #33565
This PR adds documentation for the new dynamic settings.