Apply missing request options to the expand phase #27118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds some missing options to the expand query that builds the inner hits for field collapsing. The following options are now applied to the inner_hits query: * post_filters * preferences * routing Closes elastic#27079 Closes elastic#26649
jimczi
added
:Search/Search
cbuescher
approved these changes
Oct 26, 2017
Member
cbuescher
left a comment
cbuescher
left a comment
There was a problem hiding this comment.
LGTM, I left some very minor suggestions
| if (orig.routing() != null) { | ||
| groupRequest.routing(orig.routing()); | ||
| } | ||
| if (orig.searchType() != null) { |
Member
There was a problem hiding this comment.
nit: looks like searchType cannot be null
| .indicesOptions(orig.indicesOptions()) | ||
| .requestCache(orig.requestCache()); | ||
| groupRequest.setMaxConcurrentShardRequests(orig.getMaxConcurrentShardRequests()); | ||
| if (orig.preference() != null) { |
Member
There was a problem hiding this comment.
nit: maybe the null check isn't necessary
| if (orig.preference() != null) { | ||
| groupRequest.preference(orig.preference()); | ||
| } | ||
| if (orig.routing() != null) { |
Member
There was a problem hiding this comment.
nit: maybe the null check isn't necessary
jasontedor
added a commit
to olcbean/elasticsearch
that referenced
this pull request
Oct 30, 2017
* master: (63 commits) [Docs] Fix note in bucket_selector [Docs] Fix indentation of examples (elastic#27168) [Docs] Clarify `span_not` query behavior for non-overlapping matches (elastic#27150) [Docs] Remove first person "I" from getting started (elastic#27155) [Docs] Correct link target for datatype murmur3 (elastic#27143) Fix division by zero in phrase suggester that causes assertion to fail Enable Docstats with totalSizeInBytes for 6.1.0 Adds average document size to DocsStats (elastic#27117) Upgrade Painless from ANTLR 4.5.1-1 to ANTLR 4.5.3. (elastic#27153) Exists template needs a template name (elastic#25988) [Tests] Fix occasional test failure due to two random values being the same Fix beidermorse phonetic token filter for unspecified `languageset` (elastic#27112) Fix max score tracking with field collapsing (elastic#27122) [Doc] Add Ingest CSV Processor Plugin to plugin as a community plugin (elastic#27105) Removed the beta tag from cross-cluster search fixed typo in ConstructingObjectParse (elastic#27129) Allow for the Painless Definition to have multiple instances (elastic#27096) Apply missing request options to the expand phase (elastic#27118) Only pull SegmentReader once in getSegmentInfo (elastic#27121) Fix BWC for discovery stats ...
|
Hi! Would you mind backporting this fix to 5.6? #26649 is a major bug for us and we are unfortunately not ready for 6.x yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds some missing options to the expand query that builds the inner hits for field collapsing.
The following options are now applied to the inner_hits query:
Closes #27079
Closes #26649