Skip to content

Conversation

@javanna
Copy link
Member

@javanna javanna commented Jul 6, 2017

We previously grouped all the license and notice files for httpcore, httpcore-nio, httpclient and httpasyncclient under the same license and notice file. There were though subtle differences between those which we didn't keep track of. For instance the httpcore license file has slightly changed since 4.4 which we have missed to track.

This commit goes back to having one license and notice file for each jar, to be completely sure that each dependency is associated with exactly the right licene and notice file.

Closes #25567

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

We previously grouped all the license and notice files for httpcore, httpcore-nio, httpclient and httpasyncclient under the same license and notice file. There were though subtle differences between those which we didn't keep track of. For instance the httpcore license file has slightly changed since 4.4 which we have missed to track.

This commit goes back to having one license and notice file for each jar, to be completely sure that each dependency is associated with exactly the right licene and notice file.

 Closes elastic#25567
@javanna javanna added :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch :Delivery/Build Build or test infrastructure review v5.6.0 v6.0.0 labels Jul 6, 2017
@javanna javanna requested a review from tlrx July 6, 2017 11:28
@javanna javanna merged commit bd6d7f1 into elastic:master Jul 6, 2017
javanna added a commit that referenced this pull request Jul 6, 2017
We previously grouped all the license and notice files for httpcore, httpcore-nio, httpclient and httpasyncclient under the same license and notice file. There were though subtle differences between those which we didn't keep track of. For instance the httpcore license file has slightly changed since 4.4 which we have missed to track.

This commit goes back to having one license and notice file for each jar, to be completely sure that each dependency is associated with exactly the right licene and notice file.

 Closes #25567
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jul 6, 2017
* master:
  Fix cluster health wait conditions in rolling restart tests
  Add cluster name validation to RemoteClusterConnection (elastic#25568)
  Removes deprecated usage of the FieldStats API in a test that verifies sequence number data in Lucene commit points.  Instead, the test retrieves the _seq_no value from the commit point directly and converts it to a Long value.
  [Tests] Check output of SuggestionBuilder#build method (elastic#25549)
  [Docs] Document Bulk Processor for Java High Level REST Client (elastic#25572)
  Update REST client deps license and notice files (elastic#25573)
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v5.6.0 v6.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

License description file is out of date for httpcore 4.4.5

5 participants