Fix scaled_float numeric type in aggregations #22351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`scaled_float` should be used as FLOAT in aggregations but currently they are used as LONG. This change fixes this issue and adds a simple it test for it.
jpountz
approved these changes
Dec 26, 2016
| /** | ||
| * {@link ScaledFloatLeafFieldData#getDoubleValues()} transforms the raw long values in `scaled` floats. | ||
| */ | ||
| return NumericType.FLOAT; |
Contributor
There was a problem hiding this comment.
I don't think that will change anything in practice, but I think the correct value would be DOUBLE?
jimczi
added a commit
that referenced
this pull request
Dec 27, 2016
`scaled_float` should be used as DOUBLE in aggregations but currently they are used as LONG. This change fixes this issue and adds a simple it test for it. Fixes #22350
Contributor
Author
|
Thanks @jpountz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scaled_floatshould be used as FLOAT in aggregations but currently they are used as LONG.This change fixes this issue and adds a simple it test for it.
Fixes #22350