ESQL: Replace any Attribute type when pushing down past Project #135295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow any attribute type be replaced in rule that's being pushed down past a Project. So far only `ReferenceAttribute`s were replaced. Some nodes reference other types, like `FieldAttribute` (like `OrderBy`), which would otherwise be pushed down unchanged, and thus wrongly.
bpintea
added
>bug
auto-backport
Collaborator
|
Hi @bpintea, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
approved these changes
Oct 9, 2025
Contributor
alex-spies
left a comment
alex-spies
left a comment
There was a problem hiding this comment.
Thanks @bpintea , looking good!
Contributor
Author
|
Thanks, Alex! |
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Oct 9, 2025
…tic#135295) This will allow any attribute type be replaced in node that's being pushed down past a `Project`. So far only `ReferenceAttribute`s were replaced. Some nodes reference other types, like `FieldAttribute` (in `OrderBy`), which would otherwise be pushed down unchanged, and thus possibly wrongly (such as when the `Project` renames _to_ the field attribute name, thus showdowing it). Closes elastic#134407
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 9, 2025
) (#136275) This will allow any attribute type be replaced in node that's being pushed down past a `Project`. So far only `ReferenceAttribute`s were replaced. Some nodes reference other types, like `FieldAttribute` (in `OrderBy`), which would otherwise be pushed down unchanged, and thus possibly wrongly (such as when the `Project` renames _to_ the field attribute name, thus showdowing it). Closes #134407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow any attribute type be replaced in node that's being pushed down past a
Project. So far onlyReferenceAttributes were replaced. Some nodes reference other types, likeFieldAttribute(inOrderBy), which would otherwise be pushed down unchanged, and thus possibly wrongly (such as when theProjectrenames to the field attribute name, thus showdowing it).Closes #134407