Skip to content

ESQL: add scalb function #127696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shmuelhanoch merged 1 commit into from
May 22, 2025
Merged

ESQL: add scalb function #127696

shmuelhanoch merged 1 commit into from
May 22, 2025

Conversation

@shmuelhanoch
Copy link
Contributor

@shmuelhanoch shmuelhanoch commented May 5, 2025

Part of #98545.

@cla-checker-service
Copy link

cla-checker-service bot commented May 5, 2025 •
edited
Loading

💚 CLA has been signed

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.1.0 labels May 5, 2025
@shmuelhanoch shmuelhanoch added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 5, 2025
@elasticsearchmachine elasticsearchmachine removed the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 5, 2025
@luigidellaquila luigidellaquila added >enhancement and removed needs:triage Requires assignment of a team area label labels May 5, 2025
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label May 5, 2025
@luigidellaquila luigidellaquila added :Analytics/ES|QL AKA ESQL and removed needs:triage Requires assignment of a team area label labels May 5, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 5, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 5, 2025

Pinging @elastic/es-analytical-engine (Team:Analytics)

luigidellaquila
luigidellaquila reviewed May 5, 2025
View reviewed changes
Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shmuelhanoch

I'm adding here some notes about what we discussed off-line

@luigidellaquila
Copy link
Contributor

luigidellaquila commented May 6, 2025

Please also add some tests for pathological cases, like very large numbers and null values.

@nik9000 nik9000 mentioned this pull request May 6, 2025
Open
@shmuelhanoch shmuelhanoch force-pushed the esql-add-scalb-function branch from d195b7a to f0509dc Compare May 7, 2025 10:24
@shmuelhanoch shmuelhanoch force-pushed the esql-add-scalb-function branch from 1b913c2 to 0ba09bf Compare May 7, 2025 16:47
@shmuelhanoch shmuelhanoch force-pushed the esql-add-scalb-function branch from 5b8b482 to e9a5411 Compare May 7, 2025 17:37
@shmuelhanoch shmuelhanoch force-pushed the esql-add-scalb-function branch from e9a5411 to fe3b312 Compare May 7, 2025 17:48
@shmuelhanoch shmuelhanoch force-pushed the esql-add-scalb-function branch from fe3b312 to 65d1212 Compare May 8, 2025 08:47
@shmuelhanoch shmuelhanoch force-pushed the esql-add-scalb-function branch from 741461d to 96896de Compare May 21, 2025 09:37
luigidellaquila
luigidellaquila reviewed May 21, 2025
View reviewed changes
Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shmuelhanoch

One more thing about docs: please add the function also to
https://github.com/elastic/elasticsearch/blob/main/docs/reference/query-languages/esql/_snippets/lists/math-functions.md
and
https://github.com/elastic/elasticsearch/blob/main/docs/reference/query-languages/esql/functions-operators/math-functions.md

@craigtaverner we need both with the new docs, right...?

@shmuelhanoch shmuelhanoch force-pushed the esql-add-scalb-function branch from 96896de to 5f64606 Compare May 21, 2025 11:40
@shmuelhanoch shmuelhanoch force-pushed the esql-add-scalb-function branch from 5f64606 to f1f939a Compare May 21, 2025 12:25
luigidellaquila
luigidellaquila reviewed May 21, 2025
View reviewed changes
Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shmuelhanoch, I think we are almost there. Just one small thing about a csv test

@shmuelhanoch shmuelhanoch force-pushed the esql-add-scalb-function branch from f1f939a to e68b48e Compare May 21, 2025 14:30
@shmuelhanoch shmuelhanoch force-pushed the esql-add-scalb-function branch from e68b48e to 26448d4 Compare May 21, 2025 14:32
luigidellaquila
luigidellaquila approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@shmuelhanoch shmuelhanoch merged commit db644e2 into elastic:main May 22, 2025
18 checks passed
@tylerperk
Copy link

tylerperk commented May 29, 2025

Hi @luigidellaquila @shmuelhanoch can this be backported to 8.19.0?

@luigidellaquila
Copy link
Contributor

luigidellaquila commented May 30, 2025

@tylerperk I'll take care of it

luigidellaquila pushed a commit to luigidellaquila/elasticsearch that referenced this pull request Jun 3, 2025
@shmuelhanoch @luigidellaquila
Added esql scalb function. (elastic#127696)
a47d96a 
Co-authored-by: Shmuel Hanoch <[email protected]>
@luigidellaquila luigidellaquila mentioned this pull request Jun 3, 2025
Merged
@luigidellaquila
Copy link
Contributor

luigidellaquila commented Jun 3, 2025

Manual backport here #128815

elasticsearchmachine pushed a commit that referenced this pull request Jun 3, 2025
@luigidellaquila @shmuelhanoch
Added esql scalb function. (#127696) (#128815)
040d629 
Co-authored-by: shmuelhanoch <[email protected]>
Co-authored-by: Shmuel Hanoch <[email protected]>
@leemthompo
Copy link
Contributor

leemthompo commented Jul 23, 2025 •
edited
Loading

@shmuelhanoch @luigidellaquila don't forget that nowadays we need to add applies_to tags for all docs changes (example), because we don't publish on separate minor branches. Can you confirm:

  • scalb is introduced in 9.1?
  • it's straight to GA, or is it preview?

I'll open PR to fix :-)

leemthompo added a commit to leemthompo/elasticsearch that referenced this pull request Jul 24, 2025
@leemthompo
Add applies to to ScalB function in elastic#127696
1b4a458
@leemthompo leemthompo mentioned this pull request Jul 24, 2025
Merged
leemthompo added a commit that referenced this pull request Jul 28, 2025
@leemthompo
[DOCS] Update ES|QL applies to's (#131805)
5d565b5 
* Add applies to to ScalB function in #127696

* Add applies_to to categorize, follow up to #129398

* Add version info, following #127629

* SAMPLE is new + GA in 9.1 #127629

* add applies to for 9.2 option
leemthompo added a commit to leemthompo/elasticsearch that referenced this pull request Jul 28, 2025
@leemthompo
[DOCS] Update ES|QL applies to's (elastic#131805)
cc30c5b 
* Add applies to to ScalB function in elastic#127696

* Add applies_to to categorize, follow up to elastic#129398

* Add version info, following elastic#127629

* SAMPLE is new + GA in 9.1 elastic#127629

* add applies to for 9.2 option

(cherry picked from commit 5d565b5)

# Conflicts:
#	docs/reference/query-languages/esql/_snippets/functions/parameters/categorize.md
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/grouping/Categorize.java
elasticsearchmachine pushed a commit that referenced this pull request Jul 28, 2025
@leemthompo
[DOCS] Update ES|QL applies to's (#131805) (#131989)
febd41c 
* Add applies to to ScalB function in #127696

* Add applies_to to categorize, follow up to #129398

* Add version info, following #127629

* SAMPLE is new + GA in 9.1 #127629

* add applies to for 9.2 option

(cherry picked from commit 5d565b5)

# Conflicts:
#	docs/reference/query-languages/esql/_snippets/functions/parameters/categorize.md
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/grouping/Categorize.java
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Jul 28, 2025
@leemthompo @afoucret
[DOCS] Update ES|QL applies to's (elastic#131805)
6a6da02 
* Add applies to to ScalB function in elastic#127696

* Add applies_to to categorize, follow up to elastic#129398

* Add version info, following elastic#127629

* SAMPLE is new + GA in 9.1 elastic#127629

* add applies to for 9.2 option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luigidellaquila luigidellaquila luigidellaquila approved these changes

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shmuelhanoch @elasticsearchmachine @luigidellaquila @tylerperk @leemthompo