Use regexes to match monitoring tests with messages that change in v9 #124080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoop
added
:Core/Infra/Settings
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
💚 Backport successful
|
thecoop
added a commit
to thecoop/elasticsearch
that referenced
this pull request
Mar 5, 2025
…elastic#124080) The messages are changing in v9, so change to regexes that work for both old and new formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to support #120718 - these messages change in v9, so use regex that match both formats so rest compat tests continue to work