Update Gradle wrapper to 8.13 #122421

breskeby · 2025-02-12T17:37:55Z

Requires updating the ospackage plugin
Some deprecation warnings needed to be addressed (e.g. see https://docs.gradle.org/current/userguide/upgrading_version_8.html#:~:text=Gradle%20will%20emit%20a%20deprecation,as%20defining%20a%20Gradle%20property. )
make use of layout.settingsDirectory.file api to replace rootProject references across the build

elasticsearchmachine · 2025-02-26T08:41:34Z

Pinging @elastic/es-delivery (Team:Delivery)

breskeby · 2025-02-26T12:10:22Z

probably waiting with a merge till multi-project effort is in main

…ct references

elasticsearchmachine · 2025-03-03T13:11:49Z

💔 Backport failed

Status	Branch	Result
❌	8.18	Commit could not be cherrypicked due to conflicts
❌	8.x	Commit could not be cherrypicked due to conflicts
❌	9.0	Commit could not be cherrypicked due to conflicts
❌	8.16	Commit could not be cherrypicked due to conflicts
❌	8.17	Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 122421

* Fix Gradle Deprecation warning as declaring an is- property with a Boolean type has been deprecated. * Make use of new layout.settingsFolder api to address some cross project references * Fix buildParams snapshot check for multiprojet projects (cherry picked from commit e19b226) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/BaseInternalPluginBuildPlugin.java # docs/build.gradle # qa/lucene-index-compatibility/build.gradle # x-pack/qa/multi-project/core-rest-tests-with-multiple-projects/build.gradle # x-pack/qa/multi-project/xpack-rest-tests-with-multiple-projects/build.gradle

* Fix Gradle Deprecation warning as declaring an is- property with a Boolean type has been deprecated. * Make use of new layout.settingsFolder api to address some cross project references * Fix buildParams snapshot check for multiprojet projects (cherry picked from commit e19b226) # Conflicts: # docs/build.gradle # x-pack/qa/multi-project/core-rest-tests-with-multiple-projects/build.gradle # x-pack/qa/multi-project/xpack-rest-tests-with-multiple-projects/build.gradle

* Fix Gradle Deprecation warning as declaring an is- property with a Boolean type has been deprecated. * Make use of new layout.settingsFolder api to address some cross project references * Fix buildParams snapshot check for multiprojet projects (cherry picked from commit e19b226) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/BaseInternalPluginBuildPlugin.java # docs/build.gradle # qa/entitlements/build.gradle # x-pack/qa/multi-project/core-rest-tests-with-multiple-projects/build.gradle # x-pack/qa/multi-project/xpack-rest-tests-with-multiple-projects/build.gradle

* Fix Gradle Deprecation warning as declaring an is- property with a Boolean type has been deprecated. * Make use of new layout.settingsFolder api to address some cross project references * Fix buildParams snapshot check for multiprojet projects (cherry picked from commit e19b226) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/BaseInternalPluginBuildPlugin.java # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/InternalDistributionBwcSetupPlugin.java # docs/build.gradle # qa/lucene-index-compatibility/build.gradle # x-pack/qa/multi-project/core-rest-tests-with-multiple-projects/build.gradle # x-pack/qa/multi-project/xpack-rest-tests-with-multiple-projects/build.gradle

breskeby · 2025-03-03T13:53:17Z

💔 Some backports could not be created

Status	Branch	Result
✅	8.x
✅	9.0
❌	8.18	Conflict resolution was aborted by the user
✅	8.17
✅	8.16

Manual backport

To create the backport manually run:

backport --pr 122421

Questions ?

Please refer to the Backport tool documentation

breskeby · 2025-03-03T14:01:17Z

💚 All backports created successfully

Status	Branch	Result
✅	8.18

Questions ?

Please refer to the Backport tool documentation

* Fix Gradle Deprecation warning as declaring an is- property with a Boolean type has been deprecated. * Make use of new layout.settingsFolder api to address some cross project references * Fix buildParams snapshot check for multiprojet projects (cherry picked from commit e19b226) # Conflicts: # build-tools-internal/gradle/wrapper/gradle-wrapper.properties # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/BaseInternalPluginBuildPlugin.java # build-tools-internal/src/main/resources/minimumGradleVersion # docs/build.gradle # gradle/wrapper/gradle-wrapper.properties # plugins/examples/gradle/wrapper/gradle-wrapper.properties # qa/lucene-index-compatibility/build.gradle # x-pack/qa/multi-project/core-rest-tests-with-multiple-projects/build.gradle # x-pack/qa/multi-project/xpack-rest-tests-with-multiple-projects/build.gradle

This reverts commit e19b226.

) This reverts commit 36660f2.

This reverts commit 36660f2.

* Fix Gradle Deprecation warning as declaring an is- property with a Boolean type has been deprecated. * Make use of new layout.settingsFolder api to address some cross project references * Fix buildParams snapshot check for multiprojet projects (cherry picked from commit e19b226) # Conflicts: # docs/build.gradle # x-pack/qa/multi-project/core-rest-tests-with-multiple-projects/build.gradle # x-pack/qa/multi-project/xpack-rest-tests-with-multiple-projects/build.gradle

* Fix Gradle Deprecation warning as declaring an is- property with a Boolean type has been deprecated. * Make use of new layout.settingsFolder api to address some cross project references * Fix buildParams snapshot check for multiprojet projects (cherry picked from commit e19b226) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/BaseInternalPluginBuildPlugin.java # docs/build.gradle # qa/lucene-index-compatibility/build.gradle # x-pack/qa/multi-project/core-rest-tests-with-multiple-projects/build.gradle # x-pack/qa/multi-project/xpack-rest-tests-with-multiple-projects/build.gradle

* Fix Gradle Deprecation warning as declaring an is- property with a Boolean type has been deprecated. * Make use of new layout.settingsFolder api to address some cross project references * Fix buildParams snapshot check for multiprojet projects (cherry picked from commit e19b226) # Conflicts: # build-tools-internal/gradle/wrapper/gradle-wrapper.properties # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/BaseInternalPluginBuildPlugin.java # build-tools-internal/src/main/resources/minimumGradleVersion # docs/build.gradle # gradle/wrapper/gradle-wrapper.properties # plugins/examples/gradle/wrapper/gradle-wrapper.properties # qa/lucene-index-compatibility/build.gradle # x-pack/qa/multi-project/core-rest-tests-with-multiple-projects/build.gradle # x-pack/qa/multi-project/xpack-rest-tests-with-multiple-projects/build.gradle

* Fix Gradle Deprecation warning as declaring an is- property with a Boolean type has been deprecated. * Make use of new layout.settingsFolder api to address some cross project references * Fix buildParams snapshot check for multiprojet projects (cherry picked from commit e19b226) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/BaseInternalPluginBuildPlugin.java # docs/build.gradle # qa/entitlements/build.gradle # x-pack/qa/multi-project/core-rest-tests-with-multiple-projects/build.gradle # x-pack/qa/multi-project/xpack-rest-tests-with-multiple-projects/build.gradle

* Update Gradle wrapper to 8.13 (#122421) * Fix Gradle Deprecation warning as declaring an is- property with a Boolean type has been deprecated. * Make use of new layout.settingsFolder api to address some cross project references * Fix buildParams snapshot check for multiprojet projects (cherry picked from commit e19b226) # Conflicts: # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/BaseInternalPluginBuildPlugin.java # build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/InternalDistributionBwcSetupPlugin.java # docs/build.gradle # qa/lucene-index-compatibility/build.gradle # x-pack/qa/multi-project/core-rest-tests-with-multiple-projects/build.gradle # x-pack/qa/multi-project/xpack-rest-tests-with-multiple-projects/build.gradle * More fixes

) (elastic#123896) This reverts commit 36660f2.

breskeby requested a review from a team as a code owner February 12, 2025 17:37

breskeby marked this pull request as draft February 12, 2025 17:38

breskeby changed the title ~~Update gradle wrapper 813~~ Update gradle wrapper to 8.13-rc-1 Feb 12, 2025

breskeby self-assigned this Feb 12, 2025

elasticsearchmachine added the v9.1.0 label Feb 12, 2025

breskeby added >non-issue v8.18.1 v8.19.0 v9.0.1 v8.16.5 v8.17.3 :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team labels Feb 12, 2025

breskeby force-pushed the update-gradle-wrapper-813 branch from 8fda0ae to 9e12565 Compare February 12, 2025 18:08

breskeby added the auto-backport Automatically create backport pull requests when merged label Feb 12, 2025

breskeby force-pushed the update-gradle-wrapper-813 branch 3 times, most recently from 005d29d to 6948cb9 Compare February 13, 2025 16:39

elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Feb 14, 2025

breskeby changed the title ~~Update gradle wrapper to 8.13-rc-1~~ Update Gradle wrapper to 8.13-rc-2 Feb 20, 2025

breskeby removed the request for review from a team February 21, 2025 11:41

breskeby force-pushed the update-gradle-wrapper-813 branch 2 times, most recently from 75b9d13 to 3858f60 Compare February 24, 2025 00:14

breskeby changed the title ~~Update Gradle wrapper to 8.13-rc-2~~ Update Gradle wrapper to 8.13 Feb 26, 2025

breskeby marked this pull request as ready for review February 26, 2025 08:40

breskeby requested a review from a team February 26, 2025 08:41

breskeby force-pushed the update-gradle-wrapper-813 branch from a79f9cb to 35fecc5 Compare February 26, 2025 15:55

breskeby requested a review from jozala February 26, 2025 21:01

breskeby added 4 commits February 28, 2025 22:58

Update Gradle wrapper to 8.13

45009fd

Some polishing

eb4f163

Make use of new layout.settingsFolder api to address some cross proje…

c439fbe

…ct references

Fix buildParams snapshot check for multiprojet projects

19dd9a5

breskeby force-pushed the update-gradle-wrapper-813 branch from 1070fbc to 19dd9a5 Compare February 28, 2025 21:58

breskeby merged commit e19b226 into elastic:main Mar 3, 2025
17 checks passed

elasticsearchmachine added the backport pending label Mar 3, 2025

breskeby mentioned this pull request Mar 3, 2025

[8.x] Update Gradle wrapper to 8.13 (#122421) #123873

Merged

breskeby mentioned this pull request Mar 3, 2025

[9.0] Update Gradle wrapper to 8.13 (#122421) #123874

Merged

breskeby mentioned this pull request Mar 3, 2025

[8.17] Update Gradle wrapper to 8.13 (#122421) #123875

Merged

breskeby mentioned this pull request Mar 3, 2025

[8.16] Update Gradle wrapper to 8.13 (#122421) #123876

Merged

breskeby mentioned this pull request Mar 3, 2025

[8.18] Update Gradle wrapper to 8.13 (#122421) #123878

Merged

breskeby added a commit to breskeby/elasticsearch that referenced this pull request Mar 3, 2025

Revert "Update Gradle wrapper to 8.13 (elastic#122421)"

bc3defc

This reverts commit e19b226.

breskeby added a commit that referenced this pull request Mar 3, 2025

Revert "Update Gradle wrapper to 8.13 (#122421)" (#123889)

36660f2

This reverts commit e19b226.

breskeby added a commit to breskeby/elasticsearch that referenced this pull request Mar 3, 2025

Reapply "Update Gradle wrapper to 8.13 (elastic#122421)" (elastic#123889

6d52d71

) This reverts commit 36660f2.

breskeby added a commit that referenced this pull request Mar 5, 2025

Reapply "Update Gradle wrapper to 8.13 (#122421)" (#123889) (#123896)

496c38e

This reverts commit 36660f2.

georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Mar 11, 2025

Reapply "Update Gradle wrapper to 8.13 (elastic#122421)" (elastic#123889

ab147e0

) (elastic#123896) This reverts commit 36660f2.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update Gradle wrapper to 8.13 #122421

Update Gradle wrapper to 8.13 #122421

Uh oh!

breskeby commented Feb 12, 2025 •

edited

Loading

Uh oh!

elasticsearchmachine commented Feb 26, 2025

Uh oh!

breskeby commented Feb 26, 2025

Uh oh!

Uh oh!

elasticsearchmachine commented Mar 3, 2025

Uh oh!

breskeby commented Mar 3, 2025

Uh oh!

breskeby commented Mar 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Update Gradle wrapper to 8.13 #122421

Update Gradle wrapper to 8.13 #122421

Uh oh!

Conversation

breskeby commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticsearchmachine commented Feb 26, 2025

Uh oh!

breskeby commented Feb 26, 2025

Uh oh!

Uh oh!

elasticsearchmachine commented Mar 3, 2025

💔 Backport failed

Uh oh!

breskeby commented Mar 3, 2025

💔 Some backports could not be created

Manual backport

Questions ?

Uh oh!

breskeby commented Mar 3, 2025

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

breskeby commented Feb 12, 2025 •

edited

Loading