Fix enrich cache size setting name #117576
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enrich cache size setting accidentally got renamed from `enrich.cache_size` to `enrich.cache.size` in elastic#111412. This commit ensures we accept both versions, to avoid breaking BWC twice.
nielsbauman
added
>bug
:Data Management/Ingest Node
Collaborator
|
Hi @nielsbauman, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
mattc58
requested changes
Nov 26, 2024
x-pack/plugin/enrich/src/main/java/org/elasticsearch/xpack/enrich/EnrichPlugin.java
Show resolved
Hide resolved
x-pack/plugin/enrich/src/main/java/org/elasticsearch/xpack/enrich/EnrichPlugin.java
Show resolved
Hide resolved
Contributor
Author
|
Closing this one because #117575 now already incorporates these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enrich cache size setting accidentally got renamed from
enrich.cache_sizetoenrich.cache.sizein #111412. This commit ensures we accept both versions, to avoid breaking BWC twice.This is a manual (and altered) backport of #117575.