diff --git a/docs/changelog/111683.yaml b/docs/changelog/111683.yaml new file mode 100644 index 0000000000000..cbb2e5ad71ddc --- /dev/null +++ b/docs/changelog/111683.yaml @@ -0,0 +1,6 @@ +pr: 111683 +summary: Only emit product origin in deprecation log if present +area: Infra/Logging +type: bug +issues: + - 81757 diff --git a/server/src/main/java/org/elasticsearch/common/logging/DeprecatedMessage.java b/server/src/main/java/org/elasticsearch/common/logging/DeprecatedMessage.java index 80aeaffaabec5..7f94e8d3d1824 100644 --- a/server/src/main/java/org/elasticsearch/common/logging/DeprecatedMessage.java +++ b/server/src/main/java/org/elasticsearch/common/logging/DeprecatedMessage.java @@ -62,10 +62,12 @@ private static ESLogMessage getEsLogMessage( .field(KEY_FIELD_NAME, key) .field("elasticsearch.event.category", category.name().toLowerCase(Locale.ROOT)); - if (Strings.isNullOrEmpty(xOpaqueId)) { - return esLogMessage; + if (Strings.isNullOrEmpty(xOpaqueId) == false) { + esLogMessage.field(X_OPAQUE_ID_FIELD_NAME, xOpaqueId); } - - return esLogMessage.field(X_OPAQUE_ID_FIELD_NAME, xOpaqueId).field(ELASTIC_ORIGIN_FIELD_NAME, productOrigin); + if (Strings.isNullOrEmpty(productOrigin) == false) { + esLogMessage.field(ELASTIC_ORIGIN_FIELD_NAME, productOrigin); + } + return esLogMessage; } }