Skip to content

Replace Agg integration tests with AggregatorTestCase #42893

@polyfractal

Description

@polyfractal

Similar in spirit to #36015, but with the goal of removing unecessary metric/bucket agg IT. Unlike the pipeline aggs, it should be very straightforward to replace, and I think we can probably remove most of the existing ESIntegTestCase tests

Some of these aggs do already have an AggregatorTestCase, so we should evaluate if the IT has something the unit test does not, migrate if possible and decide if the IT is useful otherwise.

A quick skim shows a lot of the IT deal with scripts, unmapped fields, formatting, etc. It's not clear to me right now if we can test some of these (notably scripts) outside of an IT. So that might be a reason to keep the IT around.

Metrics

Bucket

  • StringTermsIT
  • AdjacencyMatrixIT
  • BooleanTermsIT
  • DateHistogramIT
  • DateHistogramOffsetIT
  • DateRangeIT
  • DiversifiedSamplerIT
  • DoubleTermsIT
  • FilterIT
  • FiltersIT
  • GeoDistanceIT
  • GeoHashGridIT
  • GeoDistanceIT
  • GlobalIT
  • HistogramIT
  • IpRangeIT
  • IpTermsIT
  • LongTermsIT
  • MinDocCountIT
  • MissingIT (migrate tests from MissingIT to MissingAggregatorTests #53448)
  • NaNSortingIT
  • RangeIT
  • ReverseNestedIT
  • SamplerIT
  • ShardREduceIT
  • ShardSizeTermsIT
  • SignificantTermsSignificanceScoreIT
  • NestedIT
  • TermsDocCountErrorIT
  • TermsShardMinDocCountIT

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions