Skip to content

Commit f9029b0

Browse files
author
Hendrik Muhs
committed
apply spotless
1 parent f74d2c8 commit f9029b0

File tree

2 files changed

+69
-45
lines changed

2 files changed

+69
-45
lines changed

x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/TransformInfoTransportAction.java

Lines changed: 41 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
import java.util.Arrays;
3838
import java.util.List;
3939

40-
4140
public class TransformInfoTransportAction extends XPackInfoFeatureTransportAction {
4241

4342
private final boolean enabled;
@@ -58,12 +57,15 @@ public class TransformInfoTransportAction extends XPackInfoFeatureTransportActio
5857
TransformIndexerStats.SEARCH_FAILURES.getPreferredName(),
5958
TransformIndexerStats.EXPONENTIAL_AVG_CHECKPOINT_DURATION_MS.getPreferredName(),
6059
TransformIndexerStats.EXPONENTIAL_AVG_DOCUMENTS_INDEXED.getPreferredName(),
61-
TransformIndexerStats.EXPONENTIAL_AVG_DOCUMENTS_PROCESSED.getPreferredName(),
62-
};
60+
TransformIndexerStats.EXPONENTIAL_AVG_DOCUMENTS_PROCESSED.getPreferredName(), };
6361

6462
@Inject
65-
public TransformInfoTransportAction(TransportService transportService, ActionFilters actionFilters,
66-
Settings settings, XPackLicenseState licenseState) {
63+
public TransformInfoTransportAction(
64+
TransportService transportService,
65+
ActionFilters actionFilters,
66+
Settings settings,
67+
XPackLicenseState licenseState
68+
) {
6769
super(XPackInfoFeatureAction.TRANSFORM.name(), transportService, actionFilters);
6870
this.enabled = XPackSettings.TRANSFORM_ENABLED.get(settings);
6971
this.licenseState = licenseState;
@@ -87,16 +89,17 @@ public boolean enabled() {
8789
static TransformIndexerStats parseSearchAggs(SearchResponse searchResponse) {
8890
List<Double> statisticsList = new ArrayList<>(PROVIDED_STATS.length);
8991

90-
for(String statName : PROVIDED_STATS) {
92+
for (String statName : PROVIDED_STATS) {
9193
Aggregation agg = searchResponse.getAggregations().get(statName);
9294

9395
if (agg instanceof NumericMetricsAggregation.SingleValue) {
94-
statisticsList.add(((NumericMetricsAggregation.SingleValue)agg).value());
96+
statisticsList.add(((NumericMetricsAggregation.SingleValue) agg).value());
9597
} else {
9698
statisticsList.add(0.0);
9799
}
98100
}
99-
return new TransformIndexerStats(statisticsList.get(0).longValue(), // numPages
101+
return new TransformIndexerStats(
102+
statisticsList.get(0).longValue(), // numPages
100103
statisticsList.get(1).longValue(), // numInputDocuments
101104
statisticsList.get(2).longValue(), // numOutputDocuments
102105
statisticsList.get(3).longValue(), // numInvocations
@@ -108,47 +111,48 @@ static TransformIndexerStats parseSearchAggs(SearchResponse searchResponse) {
108111
statisticsList.get(9).longValue(), // searchFailures
109112
statisticsList.get(10), // exponential_avg_checkpoint_duration_ms
110113
statisticsList.get(11), // exponential_avg_documents_indexed
111-
statisticsList.get(12)); // exponential_avg_documents_processed
114+
statisticsList.get(12)
115+
); // exponential_avg_documents_processed
112116
}
113117

114118
static void getStatisticSummations(Client client, ActionListener<TransformIndexerStats> statsListener) {
115-
QueryBuilder queryBuilder = QueryBuilders.constantScoreQuery(QueryBuilders.boolQuery()
116-
.filter(QueryBuilders.termQuery(TransformField.INDEX_DOC_TYPE.getPreferredName(),
117-
TransformStoredDoc.NAME)));
119+
QueryBuilder queryBuilder = QueryBuilders.constantScoreQuery(
120+
QueryBuilders.boolQuery()
121+
.filter(QueryBuilders.termQuery(TransformField.INDEX_DOC_TYPE.getPreferredName(), TransformStoredDoc.NAME))
122+
);
118123

119-
SearchRequestBuilder requestBuilder = client
120-
.prepareSearch(
121-
TransformInternalIndexConstants.INDEX_NAME_PATTERN,
122-
TransformInternalIndexConstants.INDEX_NAME_PATTERN_DEPRECATED)
123-
.setSize(0)
124-
.setQuery(queryBuilder);
124+
SearchRequestBuilder requestBuilder = client.prepareSearch(
125+
TransformInternalIndexConstants.INDEX_NAME_PATTERN,
126+
TransformInternalIndexConstants.INDEX_NAME_PATTERN_DEPRECATED
127+
).setSize(0).setQuery(queryBuilder);
125128

126129
final String path = TransformField.STATS_FIELD.getPreferredName() + ".";
127-
for(String statName : PROVIDED_STATS) {
130+
for (String statName : PROVIDED_STATS) {
128131
requestBuilder.addAggregation(AggregationBuilders.sum(statName).field(path + statName));
129132
}
130133

131-
ActionListener<SearchResponse> getStatisticSummationsListener = ActionListener.wrap(
132-
searchResponse -> {
133-
if (searchResponse.getShardFailures().length > 0) {
134-
logger.error("statistics summations search returned shard failures: {}",
135-
Arrays.toString(searchResponse.getShardFailures()));
136-
}
137-
138-
statsListener.onResponse(parseSearchAggs(searchResponse));
139-
},
140-
failure -> {
141-
if (failure instanceof ResourceNotFoundException) {
142-
statsListener.onResponse(new TransformIndexerStats());
143-
} else {
144-
statsListener.onFailure(failure);
145-
}
134+
ActionListener<SearchResponse> getStatisticSummationsListener = ActionListener.wrap(searchResponse -> {
135+
if (searchResponse.getShardFailures().length > 0) {
136+
logger.error(
137+
"statistics summations search returned shard failures: {}",
138+
Arrays.toString(searchResponse.getShardFailures())
139+
);
146140
}
147-
);
148-
ClientHelper.executeAsyncWithOrigin(client.threadPool().getThreadContext(),
141+
142+
statsListener.onResponse(parseSearchAggs(searchResponse));
143+
}, failure -> {
144+
if (failure instanceof ResourceNotFoundException) {
145+
statsListener.onResponse(new TransformIndexerStats());
146+
} else {
147+
statsListener.onFailure(failure);
148+
}
149+
});
150+
ClientHelper.executeAsyncWithOrigin(
151+
client.threadPool().getThreadContext(),
149152
ClientHelper.TRANSFORM_ORIGIN,
150153
requestBuilder.request(),
151154
getStatisticSummationsListener,
152-
client::search);
155+
client::search
156+
);
153157
}
154158
}

x-pack/plugin/transform/src/test/java/org/elasticsearch/xpack/transform/TransformInfoTransportActionTests.java

Lines changed: 28 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,11 @@ public void init() {
5151

5252
public void testAvailable() {
5353
TransformInfoTransportAction featureSet = new TransformInfoTransportAction(
54-
mock(TransportService.class), mock(ActionFilters.class), Settings.EMPTY, licenseState);
54+
mock(TransportService.class),
55+
mock(ActionFilters.class),
56+
Settings.EMPTY,
57+
licenseState
58+
);
5559
boolean available = randomBoolean();
5660
when(licenseState.isTransformAllowed()).thenReturn(available);
5761
assertThat(featureSet.available(), is(available));
@@ -62,13 +66,21 @@ public void testEnabledSetting() {
6266
Settings.Builder settings = Settings.builder();
6367
settings.put("xpack.transform.enabled", enabled);
6468
TransformInfoTransportAction featureSet = new TransformInfoTransportAction(
65-
mock(TransportService.class), mock(ActionFilters.class), settings.build(), licenseState);
69+
mock(TransportService.class),
70+
mock(ActionFilters.class),
71+
settings.build(),
72+
licenseState
73+
);
6674
assertThat(featureSet.enabled(), is(enabled));
6775
}
6876

6977
public void testEnabledDefault() {
7078
TransformInfoTransportAction featureSet = new TransformInfoTransportAction(
71-
mock(TransportService.class), mock(ActionFilters.class), Settings.EMPTY, licenseState);
79+
mock(TransportService.class),
80+
mock(ActionFilters.class),
81+
Settings.EMPTY,
82+
licenseState
83+
);
7284
assertTrue(featureSet.enabled());
7385
}
7486

@@ -77,8 +89,7 @@ public void testParseSearchAggs() {
7789
SearchResponse withEmptyAggs = mock(SearchResponse.class);
7890
when(withEmptyAggs.getAggregations()).thenReturn(emptyAggs);
7991

80-
assertThat(TransformInfoTransportAction.parseSearchAggs(withEmptyAggs),
81-
equalTo(new TransformIndexerStats()));
92+
assertThat(TransformInfoTransportAction.parseSearchAggs(withEmptyAggs), equalTo(new TransformIndexerStats()));
8293

8394
TransformIndexerStats expectedStats = new TransformIndexerStats(
8495
1, // numPages
@@ -93,7 +104,8 @@ public void testParseSearchAggs() {
93104
10, // searchFailures
94105
11.0, // exponential_avg_checkpoint_duration_ms
95106
12.0, // exponential_avg_documents_indexed
96-
13.0); // exponential_avg_documents_processed
107+
13.0 // exponential_avg_documents_processed
108+
);
97109

98110
int currentStat = 1;
99111
List<Aggregation> aggs = new ArrayList<>(PROVIDED_STATS.length);
@@ -118,8 +130,16 @@ public void testUsageDisabled() throws IOException, InterruptedException, Execut
118130
when(licenseState.isTransformAllowed()).thenReturn(true);
119131
Settings.Builder settings = Settings.builder();
120132
settings.put("xpack.transform.enabled", false);
121-
var usageAction = new TransformUsageTransportAction(mock(TransportService.class), null, null,
122-
mock(ActionFilters.class), null, settings.build(), licenseState, mock(Client.class));
133+
var usageAction = new TransformUsageTransportAction(
134+
mock(TransportService.class),
135+
null,
136+
null,
137+
mock(ActionFilters.class),
138+
null,
139+
settings.build(),
140+
licenseState,
141+
mock(Client.class)
142+
);
123143
PlainActionFuture<XPackUsageFeatureResponse> future = new PlainActionFuture<>();
124144
usageAction.masterOperation(null, null, mock(ClusterState.class), future);
125145
XPackFeatureSet.Usage usage = future.get().getUsage();

0 commit comments

Comments
 (0)