Skip to content

Commit f6203d7

Browse files
committed
Add resolve timeout to log message
This commit adds the resolve timeout to the warn log message displayed when we timeout resolving unicast hosts.
1 parent 0493ba7 commit f6203d7

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

core/src/main/java/org/elasticsearch/discovery/zen/UnicastZenPing.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ public static List<DiscoveryNode> resolveDiscoveryNodes(
271271
logger.warn(message, e);
272272
}
273273
} else {
274-
logger.warn("timed out resolving host [{}]", hostname);
274+
logger.warn("timed out after [{}] resolving host [{}]", resolveTimeout, hostname);
275275
}
276276
}
277277
return discoveryNodes;

core/src/test/java/org/elasticsearch/discovery/zen/UnicastZenPingTests.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,8 @@ public TransportAddress[] addressesFromString(String address, int perAddressLimi
474474
final TransportService transportService =
475475
new TransportService(Settings.EMPTY, transport, threadPool, TransportService.NOOP_TRANSPORT_INTERCEPTOR, null);
476476
closeables.push(transportService);
477-
final AtomicInteger idGenerator = new AtomicInteger();
477+
final AtomicInteger idGenerator = new AtomicInteger();
478+
final TimeValue resolveTimeout = TimeValue.timeValueMillis(randomIntBetween(1, 100));
478479
try {
479480
final List<DiscoveryNode> discoveryNodes = UnicastZenPing.resolveDiscoveryNodes(
480481
threadPool,
@@ -483,13 +484,13 @@ public TransportAddress[] addressesFromString(String address, int perAddressLimi
483484
1,
484485
transportService,
485486
() -> Integer.toString(idGenerator.incrementAndGet()),
486-
TimeValue.timeValueMillis(100));
487+
resolveTimeout);
487488

488489
assertThat(discoveryNodes, hasSize(1));
489490
verify(logger).trace(
490491
"resolved host [{}] to {}", "hostname1",
491492
new TransportAddress[]{new TransportAddress(TransportAddress.META_ADDRESS, 9300)});
492-
verify(logger).warn("timed out resolving host [{}]", "hostname2");
493+
verify(logger).warn("timed out after [{}] resolving host [{}]", resolveTimeout, "hostname2");
493494
verifyNoMoreInteractions(logger);
494495
} finally {
495496
latch.countDown();

0 commit comments

Comments
 (0)