Skip to content

Commit e535df6

Browse files
authored
Fix typo in nori docs and tests (#92336)
C샤프 in English is C#, not C++. (C++ in Korean is C플플, C쁠쁠 or C플러스플러스.) The translation doesn't make sense, so I changed C++ to C#. It might be true that the writer used C샤프 as just an independent example, regardless C++, but I think it is better to align them for better understanding.
1 parent 3add0b2 commit e535df6

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

docs/plugins/analysis-nori.asciidoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ dictionary to `$ES_HOME/config/userdict_ko.txt`:
8282
[source,txt]
8383
-----------------------
8484
c++ <1>
85-
C샤프
85+
C쁠쁠
8686
세종
8787
세종시 세종 시 <2>
8888
-----------------------
@@ -176,7 +176,7 @@ PUT nori_sample
176176
"nori_user_dict": {
177177
"type": "nori_tokenizer",
178178
"decompound_mode": "mixed",
179-
"user_dictionary_rules": ["c++", "C샤프", "세종", "세종시 세종 시"]
179+
"user_dictionary_rules": ["c++", "C쁠쁠", "세종", "세종시 세종 시"]
180180
}
181181
},
182182
"analyzer": {
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Additional nouns
22
c++
3-
C샤프
3+
C쁠쁠
44
세종
5-
세종시 세종 시
5+
세종시 세종 시

plugins/analysis-nori/src/test/java/org/elasticsearch/plugin/analysis/nori/NoriAnalysisTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public void testNoriAnalyzer() throws Exception {
7575
public void testNoriAnalyzerUserDict() throws Exception {
7676
Settings settings = Settings.builder()
7777
.put("index.analysis.analyzer.my_analyzer.type", "nori")
78-
.putList("index.analysis.analyzer.my_analyzer.user_dictionary_rules", "c++", "C샤프", "세종", "세종시 세종 시")
78+
.putList("index.analysis.analyzer.my_analyzer.user_dictionary_rules", "c++", "C쁠쁠", "세종", "세종시 세종 시")
7979
.build();
8080
TestAnalysis analysis = createTestAnalysis(settings);
8181
Analyzer analyzer = analysis.indexAnalyzers.get("my_analyzer");
@@ -108,7 +108,7 @@ public void testNoriAnalyzerInvalidUserDictOption() throws Exception {
108108
Settings settings = Settings.builder()
109109
.put("index.analysis.analyzer.my_analyzer.type", "nori")
110110
.put("index.analysis.analyzer.my_analyzer.user_dictionary", "user_dict.txt")
111-
.putList("index.analysis.analyzer.my_analyzer.user_dictionary_rules", "c++", "C샤프", "세종", "세종시 세종 시")
111+
.putList("index.analysis.analyzer.my_analyzer.user_dictionary_rules", "c++", "C쁠쁠", "세종", "세종시 세종 시")
112112
.build();
113113
IllegalArgumentException exc = expectThrows(IllegalArgumentException.class, () -> createTestAnalysis(settings));
114114
assertThat(
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Additional nouns
22
c++
3-
C샤프
3+
C쁠쁠
44
세종
5-
세종시 세종 시
5+
세종시 세종 시

0 commit comments

Comments
 (0)