Skip to content

Commit d135714

Browse files
committed
Handle null retention leases in WaitForNoFollowersStep (#40477)
In some cases the retention leases can return null, causing a `NullPointerException` when waiting for no followers. This wraps those so that no NPE is thrown. Here is an example failure: ``` [2019-03-26T09:24:01,368][ERROR][o.e.x.i.IndexLifecycleRunner] [node-0] policy [deletePolicy] for index [ilm-00001] failed on step [{"phase":"delete","action":"delete","name":"wait-for-shard-history-leases"}]. Moving to ERROR step java.lang.NullPointerException: null at org.elasticsearch.xpack.core.indexlifecycle.WaitForNoFollowersStep.lambda$evaluateCondition$0(WaitForNoFollowersStep.java:60) ~[?:?] at java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:267) ~[?:1.8.0_191] at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) ~[?:1.8.0_191] at java.util.Spliterators$ArraySpliterator.tryAdvance(Spliterators.java:958) ~[?:1.8.0_191] at java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:126) ~[?:1.8.0_191] at java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:498) ~[?:1.8.0_191] at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:485) ~[?:1.8.0_191] at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471) ~[?:1.8.0_191] at java.util.stream.MatchOps$MatchOp.evaluateSequential(MatchOps.java:230) ~[?:1.8.0_191] at java.util.stream.MatchOps$MatchOp.evaluateSequential(MatchOps.java:196) ~[?:1.8.0_191] at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:1.8.0_191] at java.util.stream.ReferencePipeline.anyMatch(ReferencePipeline.java:449) ~[?:1.8.0_191] at org.elasticsearch.xpack.core.indexlifecycle.WaitForNoFollowersStep.lambda$evaluateCondition$2(WaitForNoFollowersStep.java:61) ~[?:?] at org.elasticsearch.action.ActionListener$1.onResponse(ActionListener.java:62) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT] at org.elasticsearch.action.support.ContextPreservingActionListener.onResponse(ContextPreservingActionListener.java:43) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT] at org.elasticsearch.action.support.TransportAction$1.onResponse(TransportAction.java:68) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT] at org.elasticsearch.action.support.TransportAction$1.onResponse(TransportAction.java:64) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT] at org.elasticsearch.action.support.ContextPreservingActionListener.onResponse(ContextPreservingActionListener.java:43) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT] at org.elasticsearch.action.support.broadcast.node.TransportBroadcastByNodeAction$AsyncAction.onCompletion(TransportBroadcastByNodeAction.java:383) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT] at org.elasticsearch.action.support.broadcast.node.TransportBroadcastByNodeAction$AsyncAction.onNodeResponse(TransportBroadcastByNodeAction.java:352) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT] at org.elasticsearch.action.support.broadcast.node.TransportBroadcastByNodeAction$AsyncAction$1.handleResponse(TransportBroadcastByNodeAction.java:324) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT] at org.elasticsearch.action.support.broadcast.node.TransportBroadcastByNodeAction$AsyncAction$1.handleResponse(TransportBroadcastByNodeAction.java:314) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT] at org.elasticsearch.transport.TransportService$ContextRestoreResponseHandler.handleResponse(TransportService.java:1095) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT] at org.elasticsearch.transport.TransportService$DirectResponseChannel.processResponse(TransportService.java:1176) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT] ... ```
1 parent 873c563 commit d135714

File tree

2 files changed

+43
-2
lines changed

2 files changed

+43
-2
lines changed

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/indexlifecycle/WaitForNoFollowersStep.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@
2020

2121
import java.io.IOException;
2222
import java.util.Arrays;
23+
import java.util.Collection;
2324
import java.util.Objects;
25+
import java.util.Optional;
2426

2527
/**
2628
* A step that waits until the index it's used on is no longer a leader index.
@@ -57,8 +59,11 @@ public void evaluateCondition(IndexMetaData indexMetaData, Listener listener) {
5759

5860
boolean isCurrentlyLeaderIndex = Arrays.stream(indexStats.getShards())
5961
.map(ShardStats::getRetentionLeaseStats)
60-
.flatMap(retentionLeaseStats -> retentionLeaseStats.retentionLeases().leases().stream())
61-
.anyMatch(lease -> CCR_LEASE_KEY.equals(lease.source()));
62+
.map(Optional::ofNullable)
63+
.map(o -> o.flatMap(stats -> Optional.ofNullable(stats.retentionLeases())))
64+
.map(o -> o.flatMap(leases -> Optional.ofNullable(leases.leases())))
65+
.map(o -> o.map(Collection::stream))
66+
.anyMatch(lease -> lease.isPresent() && lease.get().anyMatch(l -> CCR_LEASE_KEY.equals(l.source())));
6267

6368
if (isCurrentlyLeaderIndex) {
6469
listener.onResponse(false, new Info());

x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/indexlifecycle/WaitForNoFollowersStepTests.java

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,42 @@ public void onFailure(Exception e) {
132132
containsString("this index is a leader index; waiting for all following indices to cease following before proceeding"));
133133
}
134134

135+
public void testNoShardStats() {
136+
WaitForNoFollowersStep step = createRandomInstance();
137+
138+
String indexName = randomAlphaOfLengthBetween(5,10);
139+
140+
int numberOfShards = randomIntBetween(1, 100);
141+
final IndexMetaData indexMetaData = IndexMetaData.builder(indexName)
142+
.settings(settings(Version.CURRENT))
143+
.numberOfShards(numberOfShards)
144+
.numberOfReplicas(randomIntBetween(1, 10))
145+
.build();
146+
147+
ShardStats sStats = new ShardStats(null, mockShardPath(), null, null, null, null);
148+
ShardStats[] shardStats = new ShardStats[1];
149+
shardStats[0] = sStats;
150+
mockIndexStatsCall(step.getClient(), indexName, new IndexStats(indexName, "uuid", shardStats));
151+
152+
final SetOnce<Boolean> conditionMetHolder = new SetOnce<>();
153+
final SetOnce<ToXContentObject> stepInfoHolder = new SetOnce<>();
154+
step.evaluateCondition(indexMetaData, new AsyncWaitStep.Listener() {
155+
@Override
156+
public void onResponse(boolean conditionMet, ToXContentObject infomationContext) {
157+
conditionMetHolder.set(conditionMet);
158+
stepInfoHolder.set(infomationContext);
159+
}
160+
161+
@Override
162+
public void onFailure(Exception e) {
163+
fail("onFailure should not be called in this test, called with exception: " + e.getMessage());
164+
}
165+
});
166+
167+
assertTrue(conditionMetHolder.get());
168+
assertNull(stepInfoHolder.get());
169+
}
170+
135171
public void testFailure() {
136172
WaitForNoFollowersStep step = createRandomInstance();
137173

0 commit comments

Comments
 (0)