Skip to content

Commit d0c9cf2

Browse files
committed
Merge remote-tracking branch 'es/master' into ccr
* es/master: Add Index UUID to `/_stats` Response (#31871) Painless: Move and Rename Several Methods in the lookup package (#32105) Bypass highlight query terms extraction on empty fields (#32090) Switch non-x-pack to new style requests (#32106) [Rollup] Add new capabilities endpoint for concrete rollup indices (#30401) Revert "[test] disable packaging tests for suse boxes" SQL: allow LEFT and RIGHT as function names (#32066) DOCS: put LIMIT 10 to the SQL query (#32065) [test] turn on host io cache for opensuse (#32053) Tweaked Elasticsearch Service links for SEO
2 parents f5e2168 + 4b5071f commit d0c9cf2

File tree

74 files changed

+2537
-1248
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

74 files changed

+2537
-1248
lines changed

Vagrantfile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,11 @@ Vagrant.configure(2) do |config|
115115
'opensuse-42'.tap do |box|
116116
config.vm.define box, define_opts do |config|
117117
config.vm.box = 'elastic/opensuse-42-x86_64'
118+
119+
# https://github.com/elastic/elasticsearch/issues/30295
120+
config.vm.provider 'virtualbox' do |vbox|
121+
vbox.customize ['storagectl', :id, '--name', 'SATA Controller', '--hostiocache', 'on']
122+
end
118123
suse_common config, box
119124
end
120125
end

buildSrc/src/main/groovy/org/elasticsearch/gradle/vagrant/VagrantTestPlugin.groovy

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -526,11 +526,7 @@ class VagrantTestPlugin implements Plugin<Project> {
526526
project.gradle.removeListener(batsPackagingReproListener)
527527
}
528528
if (project.extensions.esvagrant.boxes.contains(box)) {
529-
// these tests are temporarily disabled for suse boxes while we debug an issue
530-
// https://github.com/elastic/elasticsearch/issues/30295
531-
if (box.equals("opensuse-42") == false && box.equals("sles-12") == false) {
532-
packagingTest.dependsOn(batsPackagingTest)
533-
}
529+
packagingTest.dependsOn(batsPackagingTest)
534530
}
535531
}
536532

@@ -569,11 +565,7 @@ class VagrantTestPlugin implements Plugin<Project> {
569565
project.gradle.removeListener(javaPackagingReproListener)
570566
}
571567
if (project.extensions.esvagrant.boxes.contains(box)) {
572-
// these tests are temporarily disabled for suse boxes while we debug an issue
573-
// https://github.com/elastic/elasticsearch/issues/30295
574-
if (box.equals("opensuse-42") == false && box.equals("sles-12") == false) {
575-
packagingTest.dependsOn(javaPackagingTest)
576-
}
568+
packagingTest.dependsOn(javaPackagingTest)
577569
}
578570

579571
/*

docs/reference/getting-started.asciidoc

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -106,10 +106,11 @@ With that out of the way, let's get started with the fun part...
106106

107107
[TIP]
108108
==============
109-
You can skip installation completely by using our hosted
110-
Elasticsearch Service on https://www.elastic.co/cloud[Elastic Cloud], which is
111-
available on AWS and GCP. You can
112-
https://www.elastic.co/cloud/elasticsearch-service/signup[try out the hosted service] for free.
109+
You can skip having to install Elasticsearch by using our
110+
https://www.elastic.co/cloud/elasticsearch-service[hosted Elasticsearch Service]
111+
on Elastic Cloud. The Elasticsearch Service is available on both AWS and GCP.
112+
https://www.elastic.co/cloud/elasticsearch-service/signup[Try out the
113+
Elasticsearch Service for free].
113114
==============
114115

115116
Elasticsearch requires at least Java 8. Specifically as of this writing, it is recommended that you use the Oracle JDK version {jdk}. Java installation varies from platform to platform so we won't go into those details here. Oracle's recommended installation documentation can be found on http://docs.oracle.com/javase/8/docs/technotes/guides/install/install_overview.html[Oracle's website]. Suffice to say, before you install Elasticsearch, please check your Java version first by running (and then install/upgrade accordingly if needed):
@@ -1121,7 +1122,7 @@ In SQL, the above aggregation is similar in concept to:
11211122

11221123
[source,sh]
11231124
--------------------------------------------------
1124-
SELECT state, COUNT(*) FROM bank GROUP BY state ORDER BY COUNT(*) DESC
1125+
SELECT state, COUNT(*) FROM bank GROUP BY state ORDER BY COUNT(*) DESC LIMIT 10;
11251126
--------------------------------------------------
11261127

11271128
And the response (partially shown):

modules/lang-painless/src/main/java/org/elasticsearch/painless/AnalyzerCaster.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919

2020
package org.elasticsearch.painless;
2121

22-
import org.elasticsearch.painless.lookup.PainlessLookup;
2322
import org.elasticsearch.painless.lookup.PainlessCast;
23+
import org.elasticsearch.painless.lookup.PainlessLookupUtility;
2424
import org.elasticsearch.painless.lookup.def;
2525

2626
import java.util.Objects;
@@ -465,8 +465,9 @@ public static PainlessCast getLegalCast(Location location, Class<?> actual, Clas
465465
(actual.isAssignableFrom(expected) && explicit)) {
466466
return PainlessCast.standard(actual, expected, explicit);
467467
} else {
468-
throw location.createError(new ClassCastException(
469-
"Cannot cast from [" + PainlessLookup.ClassToName(actual) + "] to [" + PainlessLookup.ClassToName(expected) + "]."));
468+
throw location.createError(new ClassCastException("Cannot cast from " +
469+
"[" + PainlessLookupUtility.anyTypeToPainlessTypeName(actual) + "] to " +
470+
"[" + PainlessLookupUtility.anyTypeToPainlessTypeName(expected) + "]."));
470471
}
471472
}
472473

modules/lang-painless/src/main/java/org/elasticsearch/painless/Def.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,10 @@
1919

2020
package org.elasticsearch.painless;
2121

22+
import org.elasticsearch.painless.lookup.PainlessClass;
2223
import org.elasticsearch.painless.lookup.PainlessLookup;
24+
import org.elasticsearch.painless.lookup.PainlessLookupUtility;
2325
import org.elasticsearch.painless.lookup.PainlessMethod;
24-
import org.elasticsearch.painless.lookup.PainlessClass;
2526
import org.elasticsearch.painless.lookup.PainlessMethodKey;
2627

2728
import java.lang.invoke.CallSite;
@@ -302,7 +303,7 @@ static MethodHandle lookupMethod(PainlessLookup painlessLookup, MethodHandles.Lo
302303
nestedType,
303304
0,
304305
DefBootstrap.REFERENCE,
305-
PainlessLookup.ClassToName(interfaceType));
306+
PainlessLookupUtility.anyTypeToPainlessTypeName(interfaceType));
306307
filter = nested.dynamicInvoker();
307308
} else {
308309
throw new AssertionError();
@@ -347,7 +348,7 @@ private static MethodHandle lookupReferenceInternal(PainlessLookup painlessLooku
347348
PainlessMethod interfaceMethod = painlessLookup.getPainlessStructFromJavaClass(clazz).functionalMethod;
348349
if (interfaceMethod == null) {
349350
throw new IllegalArgumentException("Cannot convert function reference [" + type + "::" + call + "] " +
350-
"to [" + PainlessLookup.ClassToName(clazz) + "], not a functional interface");
351+
"to [" + PainlessLookupUtility.anyTypeToPainlessTypeName(clazz) + "], not a functional interface");
351352
}
352353
int arity = interfaceMethod.arguments.size() + captures.length;
353354
final MethodHandle handle;

modules/lang-painless/src/main/java/org/elasticsearch/painless/FunctionRef.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
import org.elasticsearch.painless.lookup.PainlessClass;
2323
import org.elasticsearch.painless.lookup.PainlessLookup;
24+
import org.elasticsearch.painless.lookup.PainlessLookupUtility;
2425
import org.elasticsearch.painless.lookup.PainlessMethod;
2526
import org.elasticsearch.painless.lookup.PainlessMethodKey;
2627
import org.objectweb.asm.Type;
@@ -168,7 +169,7 @@ private static PainlessMethod lookup(PainlessLookup painlessLookup, Class<?> exp
168169
PainlessMethod method = painlessLookup.getPainlessStructFromJavaClass(expected).functionalMethod;
169170
if (method == null) {
170171
throw new IllegalArgumentException("Cannot convert function reference [" + type + "::" + call + "] " +
171-
"to [" + PainlessLookup.ClassToName(expected) + "], not a functional interface");
172+
"to [" + PainlessLookupUtility.anyTypeToPainlessTypeName(expected) + "], not a functional interface");
172173
}
173174

174175
// lookup requested method

modules/lang-painless/src/main/java/org/elasticsearch/painless/Locals.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,11 @@
1919

2020
package org.elasticsearch.painless;
2121

22+
import org.elasticsearch.painless.ScriptClassInfo.MethodArgument;
2223
import org.elasticsearch.painless.lookup.PainlessLookup;
24+
import org.elasticsearch.painless.lookup.PainlessLookupUtility;
2325
import org.elasticsearch.painless.lookup.PainlessMethod;
2426
import org.elasticsearch.painless.lookup.PainlessMethodKey;
25-
import org.elasticsearch.painless.ScriptClassInfo.MethodArgument;
2627

2728
import java.util.Arrays;
2829
import java.util.Collection;
@@ -292,7 +293,7 @@ public int getSlot() {
292293
@Override
293294
public String toString() {
294295
StringBuilder b = new StringBuilder();
295-
b.append("Variable[type=").append(PainlessLookup.ClassToName(clazz));
296+
b.append("Variable[type=").append(PainlessLookupUtility.anyTypeToPainlessTypeName(clazz));
296297
b.append(",name=").append(name);
297298
b.append(",slot=").append(slot);
298299
if (readonly) {

modules/lang-painless/src/main/java/org/elasticsearch/painless/ScriptClassInfo.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
package org.elasticsearch.painless;
2121

2222
import org.elasticsearch.painless.lookup.PainlessLookup;
23+
import org.elasticsearch.painless.lookup.PainlessLookupUtility;
2324

2425
import java.lang.invoke.MethodType;
2526
import java.lang.reflect.Field;
@@ -182,7 +183,7 @@ private MethodArgument methodArgument(PainlessLookup painlessLookup, Class<?> cl
182183

183184
private static Class<?> definitionTypeForClass(PainlessLookup painlessLookup, Class<?> type,
184185
Function<Class<?>, String> unknownErrorMessageSource) {
185-
type = PainlessLookup.ObjectClassTodefClass(type);
186+
type = PainlessLookupUtility.javaObjectTypeToPainlessDefType(type);
186187
Class<?> componentType = type;
187188

188189
while (componentType.isArray()) {

modules/lang-painless/src/main/java/org/elasticsearch/painless/antlr/EnhancedPainlessLexer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
import org.antlr.v4.runtime.LexerNoViableAltException;
2424
import org.antlr.v4.runtime.Token;
2525
import org.antlr.v4.runtime.misc.Interval;
26-
import org.elasticsearch.painless.lookup.PainlessLookup;
2726
import org.elasticsearch.painless.Location;
27+
import org.elasticsearch.painless.lookup.PainlessLookup;
2828

2929
/**
3030
* A lexer that is customized for painless. It:

0 commit comments

Comments
 (0)