Rename replication test case method

This commit renames a method that is used in replication test cases to
add a replica using existing shard data.

Author: jasontedor

core/src/test/java/org/elasticsearch/index/replication/ESIndexLevelReplicationTestCase.java

@@ -50,6 +50,7 @@
 import org.elasticsearch.index.shard.IndexShard;
 import org.elasticsearch.index.shard.IndexShardTestCase;
 import org.elasticsearch.index.shard.ShardId;
+import org.elasticsearch.index.shard.ShardPath;
 import org.elasticsearch.indices.recovery.RecoveryState;
 import org.elasticsearch.indices.recovery.RecoveryTarget;
 
@@ -185,16 +186,14 @@ public synchronized IndexShard addReplica() throws IOException {
             return replica;
         }
 
-        public synchronized IndexShard addReplica(IndexShard replica) throws IOException {
-            replica.close("add", false);
-            IOUtils.close(replica.store());
-            ShardRouting shardRouting = TestShardRouting.newShardRouting(
+        public synchronized IndexShard addReplicaWithExistingPath(final ShardPath shardPath, final String nodeId) throws IOException {
+            final ShardRouting shardRouting = TestShardRouting.newShardRouting(
                 shardId,
-                replica.routingEntry().currentNodeId(),
+                nodeId,
                 false, ShardRoutingState.INITIALIZING,
                 RecoverySource.PeerRecoverySource.INSTANCE);
 
-            IndexShard newReplica = newShard(shardRouting, replica.shardPath(), indexMetaData, null, replicaGlobalCheckpointSyncer);
+            final IndexShard newReplica = newShard(shardRouting, shardPath, indexMetaData, null, replicaGlobalCheckpointSyncer);
             replicas.add(newReplica);
             updateAllocationIDsOnPrimary();
             return newReplica;

core/src/test/java/org/elasticsearch/index/replication/RecoveryDuringReplicationTests.java

@@ -20,6 +20,7 @@
 package org.elasticsearch.index.replication;
 
 import org.apache.logging.log4j.Logger;
+import org.apache.lucene.util.IOUtils;
 import org.elasticsearch.action.admin.indices.flush.FlushRequest;
 import org.elasticsearch.cluster.node.DiscoveryNode;
 import org.elasticsearch.index.shard.IndexShard;
@@ -106,7 +107,10 @@ public void testRecoveryOfDisconnectedReplica() throws Exception {
                 shards.flush();
             }
 
-            final IndexShard recoveredReplica = shards.addReplica(originalReplica);
+            originalReplica.close("disconnected", false);
+            IOUtils.close(originalReplica.store());
+            final IndexShard recoveredReplica =
+                shards.addReplicaWithExistingPath(originalReplica.shardPath(), originalReplica.routingEntry().currentNodeId());
             shards.recoverReplica(recoveredReplica);
             if (flushPrimary && replicaHasDocsSinceLastFlushedCheckpoint) {
                 // replica has something to catch up with, but since we flushed the primary, we should fall back to full recovery