Skip to content

Commit a2c29ea

Browse files
Correct errors - HRLC TermVectorRequest (#35705)
Relates to #35266, #35614
1 parent b61b3f0 commit a2c29ea

File tree

3 files changed

+7
-14
lines changed

3 files changed

+7
-14
lines changed

client/rest-high-level/src/main/java/org/elasticsearch/client/core/TermVectorsRequest.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -170,13 +170,6 @@ public void setPerFieldAnalyzer(Map<String, String> perFieldAnalyzer) {
170170
this.perFieldAnalyzer = perFieldAnalyzer;
171171
}
172172

173-
/**
174-
* Sets an artifical document on what to request _termvectors
175-
*/
176-
public void setDoc(XContentBuilder docBuilder) {
177-
this.docBuilder = docBuilder;
178-
}
179-
180173
/**
181174
* Sets conditions for terms filtering
182175
*/

client/rest-high-level/src/test/java/org/elasticsearch/client/CrudIT.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1281,7 +1281,7 @@ public void testMultiTermvectors() throws IOException {
12811281
{
12821282
// test _mtermvectors where MultiTermVectorsRequest is constructed with ids and a template
12831283
String[] expectedIds = {"1", "2"};
1284-
TermVectorsRequest tvRequestTemplate = new TermVectorsRequest(sourceIndex, "_doc");
1284+
TermVectorsRequest tvRequestTemplate = new TermVectorsRequest(sourceIndex, "_doc", "fake_id");
12851285
tvRequestTemplate.setFields("field");
12861286
MultiTermVectorsRequest mtvRequest = new MultiTermVectorsRequest(expectedIds, tvRequestTemplate);
12871287

@@ -1303,10 +1303,10 @@ public void testMultiTermvectors() throws IOException {
13031303
TermVectorsRequest tvRequest1 = new TermVectorsRequest(sourceIndex, "_doc", "1");
13041304
tvRequest1.setFields("field");
13051305
mtvRequest.add(tvRequest1);
1306-
TermVectorsRequest tvRequest2 = new TermVectorsRequest(sourceIndex, "_doc");
1306+
13071307
XContentBuilder docBuilder = XContentFactory.jsonBuilder();
13081308
docBuilder.startObject().field("field", "valuex").endObject();
1309-
tvRequest2.setDoc(docBuilder);
1309+
TermVectorsRequest tvRequest2 = new TermVectorsRequest(sourceIndex, "_doc", docBuilder);
13101310
mtvRequest.add(tvRequest2);
13111311

13121312
MultiTermVectorsResponse mtvResponse =

client/rest-high-level/src/test/java/org/elasticsearch/client/documentation/CRUDDocumentationIT.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1688,18 +1688,18 @@ public void testMultiTermVectors() throws Exception {
16881688
new TermVectorsRequest("authors", "_doc", "1");
16891689
tvrequest1.setFields("user");
16901690
request.add(tvrequest1); // <2>
1691-
TermVectorsRequest tvrequest2 =
1692-
new TermVectorsRequest("authors", "_doc");
1691+
16931692
XContentBuilder docBuilder = XContentFactory.jsonBuilder();
16941693
docBuilder.startObject().field("user", "guest-user").endObject();
1695-
tvrequest2.setDoc(docBuilder);
1694+
TermVectorsRequest tvrequest2 =
1695+
new TermVectorsRequest("authors", "_doc", docBuilder);
16961696
request.add(tvrequest2); // <3>
16971697
// end::multi-term-vectors-request
16981698
}
16991699

17001700
// tag::multi-term-vectors-request-template
17011701
TermVectorsRequest tvrequestTemplate =
1702-
new TermVectorsRequest("authors", "_doc"); // <1>
1702+
new TermVectorsRequest("authors", "_doc", "fake_id"); // <1>
17031703
tvrequestTemplate.setFields("user");
17041704
String[] ids = {"1", "2"};
17051705
MultiTermVectorsRequest request =

0 commit comments

Comments
 (0)