CCR: Rename follow-task parameters and stats (#34836)

* CCR: Rename follow parameters and stats

This commit renames the follow-task parameters and its stats.
Below are the changes:

## Params
- remote_cluster (unchanged)
- leader_index (unchanged)
- max_read_request_operation_count -> max_read_request_operation_count
- max_batch_size -> max_read_request_size
- max_write_request_operation_count (new)
- max_write_request_size (new)
- max_concurrent_read_batches -> max_outstanding_read_requests
- max_concurrent_write_batches -> max_outstanding_write_requests
- max_write_buffer_size (unchanged)
- max_write_buffer_count (unchanged)
- max_retry_delay (unchanged)
- poll_timeout -> read_poll_timeout

## Stats
- remote_cluster (unchanged)
- leader_index (unchanged)
- follower_index (unchanged)
- shard_id (unchanged)
- leader_global_checkpoint (unchanged)
- leader_max_seq_no (unchanged)
- follower_global_checkpoint (unchanged)
- follower_max_seq_no (unchanged)
- last_requested_seq_no (unchanged)
- number_of_concurrent_reads -> outstanding_read_requests
- number_of_concurrent_writes -> outstanding_write_requests
- buffer_size_in_bytes -> write_buffer_size_in_bytes (new)
- number_of_queued_writes -> write_buffer_operation_count
- mapping_version -> follower_mapping_version
- total_fetch_time_millis -> total_read_time_millis
- total_fetch_remote_time_millis -> total_read_remote_exec_time_millis
- number_of_successful_fetches -> successful_read_requests
- number_of_failed_fetches -> failed_read_requests
- operation_received -> operations_read
- total_transferred_bytes -> bytes_read
- total_index_time_millis -> total_write_time_millis [?]
- number_of_successful_bulk_operations -> successful_write_requests
- number_of_failed_bulk_operations -> failed_write_requests
- number_of_operations_indexed -> operations_written
- fetch_exception -> read_exceptions
- time_since_last_read_millis -> time_since_last_read_millis

* add test for max_write_request_(operation_count|size)

Author: dnhatn

x-pack/plugin/ccr/qa/rest/src/test/resources/rest-api-spec/test/ccr/auto_follow.yml

@@ -25,21 +25,21 @@
         body:
           remote_cluster: local
           leader_index_patterns: ['logs-*']
-          max_concurrent_read_batches: 2
+          max_outstanding_read_requests: 2
   - is_true: acknowledged
 
   - do:
       ccr.get_auto_follow_pattern:
         name: my_pattern
   - match: { my_pattern.remote_cluster: 'local' }
   - match: { my_pattern.leader_index_patterns: ['logs-*'] }
-  - match: { my_pattern.max_concurrent_read_batches: 2 }
+  - match: { my_pattern.max_outstanding_read_requests: 2 }
 
   - do:
       ccr.get_auto_follow_pattern: {}
   - match: { my_pattern.remote_cluster: 'local' }
   - match: { my_pattern.leader_index_patterns: ['logs-*'] }
-  - match: { my_pattern.max_concurrent_read_batches: 2 }
+  - match: { my_pattern.max_outstanding_read_requests: 2 }
 
   - do:
       ccr.delete_auto_follow_pattern:

x-pack/plugin/ccr/qa/rest/src/test/resources/rest-api-spec/test/ccr/follow_stats.yml

@@ -56,21 +56,21 @@
   - gte: { indices.0.shards.0.follower_global_checkpoint: -1 }
   - gte: { indices.0.shards.0.follower_max_seq_no: -1 }
   - gte: { indices.0.shards.0.last_requested_seq_no: -1 }
-  - gte: { indices.0.shards.0.number_of_concurrent_reads: 0 }
-  - match: { indices.0.shards.0.number_of_concurrent_writes: 0 }
-  - match: { indices.0.shards.0.number_of_queued_writes: 0 }
-  - gte: { indices.0.shards.0.mapping_version: 0 }
-  - gte: { indices.0.shards.0.total_fetch_time_millis: 0 }
-  - gte: { indices.0.shards.0.number_of_successful_fetches: 0 }
-  - gte: { indices.0.shards.0.number_of_failed_fetches: 0 }
-  - match: { indices.0.shards.0.operations_received: 0 }
-  - match: { indices.0.shards.0.total_transferred_bytes: 0 }
-  - match: { indices.0.shards.0.total_index_time_millis: 0 }
-  - match: { indices.0.shards.0.number_of_successful_bulk_operations: 0 }
-  - match: { indices.0.shards.0.number_of_failed_bulk_operations: 0 }
-  - match: { indices.0.shards.0.number_of_operations_indexed: 0 }
-  - length: { indices.0.shards.0.fetch_exceptions: 0 }
-  - gte: { indices.0.shards.0.time_since_last_fetch_millis: -1 }
+  - gte: { indices.0.shards.0.outstanding_read_requests: 0 }
+  - match: { indices.0.shards.0.outstanding_write_requests: 0 }
+  - match: { indices.0.shards.0.write_buffer_operation_count: 0 }
+  - gte: { indices.0.shards.0.follower_mapping_version: 0 }
+  - gte: { indices.0.shards.0.total_read_time_millis: 0 }
+  - gte: { indices.0.shards.0.successful_read_requests: 0 }
+  - gte: { indices.0.shards.0.failed_read_requests: 0 }
+  - match: { indices.0.shards.0.operations_read: 0 }
+  - match: { indices.0.shards.0.bytes_read: 0 }
+  - match: { indices.0.shards.0.total_write_time_millis: 0 }
+  - match: { indices.0.shards.0.successful_write_requests: 0 }
+  - match: { indices.0.shards.0.failed_write_requests: 0 }
+  - match: { indices.0.shards.0.operations_written: 0 }
+  - length: { indices.0.shards.0.read_exceptions: 0 }
+  - gte: { indices.0.shards.0.time_since_last_read_millis: -1 }
 
   - do:
       ccr.pause_follow:

x-pack/plugin/ccr/qa/src/main/java/org/elasticsearch/xpack/ccr/ESCCRRestTestCase.java

@@ -59,7 +59,7 @@ protected static void refresh(String index) throws IOException {
 
     protected static void resumeFollow(String followIndex) throws IOException {
         final Request request = new Request("POST", "/" + followIndex + "/_ccr/resume_follow");
-        request.setJsonEntity("{\"poll_timeout\": \"10ms\"}");
+        request.setJsonEntity("{\"read_poll_timeout\": \"10ms\"}");
         assertOK(client().performRequest(request));
     }
 
@@ -74,7 +74,7 @@ protected static void followIndex(String leaderCluster, String leaderIndex, Stri
     protected static void followIndex(RestClient client, String leaderCluster, String leaderIndex, String followIndex) throws IOException {
         final Request request = new Request("PUT", "/" + followIndex + "/_ccr/follow");
         request.setJsonEntity("{\"remote_cluster\": \"" + leaderCluster + "\", \"leader_index\": \"" + leaderIndex +
-            "\", \"poll_timeout\": \"10ms\"}");
+            "\", \"read_poll_timeout\": \"10ms\"}");
         assertOK(client.performRequest(request));
     }
 
@@ -136,10 +136,10 @@ protected static void verifyCcrMonitoring(final String expectedLeaderIndex, fina
             assertThat(followerIndex, equalTo(expectedFollowerIndex));
 
             int foundNumberOfOperationsReceived =
-                (int) XContentMapValues.extractValue("_source.ccr_stats.operations_received", hit);
+                (int) XContentMapValues.extractValue("_source.ccr_stats.operations_read", hit);
             numberOfOperationsReceived = Math.max(numberOfOperationsReceived, foundNumberOfOperationsReceived);
             int foundNumberOfOperationsIndexed =
-                (int) XContentMapValues.extractValue("_source.ccr_stats.number_of_operations_indexed", hit);
+                (int) XContentMapValues.extractValue("_source.ccr_stats.operations_written", hit);
             numberOfOperationsIndexed = Math.max(numberOfOperationsIndexed, foundNumberOfOperationsIndexed);
         }
 

x-pack/plugin/ccr/src/main/java/org/elasticsearch/xpack/ccr/action/AutoFollowCoordinator.java

@@ -324,14 +324,16 @@ private void followLeaderIndex(String autoFollowPattenName,
 
             ResumeFollowAction.Request followRequest = new ResumeFollowAction.Request();
             followRequest.setFollowerIndex(followIndexName);
-            followRequest.setMaxBatchOperationCount(pattern.getMaxBatchOperationCount());
-            followRequest.setMaxConcurrentReadBatches(pattern.getMaxConcurrentReadBatches());
-            followRequest.setMaxBatchSize(pattern.getMaxBatchSize());
-            followRequest.setMaxConcurrentWriteBatches(pattern.getMaxConcurrentWriteBatches());
+            followRequest.setMaxReadRequestOperationCount(pattern.getMaxReadRequestOperationCount());
+            followRequest.setMaxReadRequestSize(pattern.getMaxReadRequestSize());
+            followRequest.setMaxOutstandingReadRequests(pattern.getMaxOutstandingReadRequests());
+            followRequest.setMaxWriteRequestOperationCount(pattern.getMaxWriteRequestOperationCount());
+            followRequest.setMaxWriteRequestSize(pattern.getMaxWriteRequestSize());
+            followRequest.setMaxOutstandingWriteRequests(pattern.getMaxOutstandingWriteRequests());
             followRequest.setMaxWriteBufferCount(pattern.getMaxWriteBufferCount());
             followRequest.setMaxWriteBufferSize(pattern.getMaxWriteBufferSize());
             followRequest.setMaxRetryDelay(pattern.getMaxRetryDelay());
-            followRequest.setPollTimeout(pattern.getPollTimeout());
+            followRequest.setReadPollTimeout(pattern.getPollTimeout());
 
             PutFollowAction.Request request = new PutFollowAction.Request();
             request.setRemoteCluster(remoteCluster);

x-pack/plugin/ccr/src/main/java/org/elasticsearch/xpack/ccr/action/ShardChangesAction.java

@@ -65,8 +65,8 @@ public static class Request extends SingleShardRequest<Request> {
         private int maxOperationCount;
         private ShardId shardId;
         private String expectedHistoryUUID;
-        private TimeValue pollTimeout = TransportResumeFollowAction.DEFAULT_POLL_TIMEOUT;
-        private ByteSizeValue maxBatchSize = TransportResumeFollowAction.DEFAULT_MAX_BATCH_SIZE;
+        private TimeValue pollTimeout = TransportResumeFollowAction.DEFAULT_READ_POLL_TIMEOUT;
+        private ByteSizeValue maxBatchSize = TransportResumeFollowAction.DEFAULT_MAX_READ_REQUEST_SIZE;
 
         private long relativeStartNanos;