Deprecate disabling basic-license features (#54816)

We believe there's no longer a need to be able to disable basic-license
features completely using the "xpack.*.enabled" settings. If users don't
want to use those features, they simply don't need to use them. Having
such features always available lets us build more complex features that
assume basic-license features are present.

This commit deprecates settings of the form "xpack.*.enabled" for
basic-license features, excluding "security", which is a special case.
It also removes deprecated settings from integration tests and unit
tests where they're not directly relevant; e.g. monitoring and ILM are
no longer disabled in many integration tests.

Author: williamrandolph

distribution/build.gradle

@@ -449,9 +449,6 @@ testClusters {
         throw new IllegalArgumentException("Unsupported self-generated license type: [" + licenseType + "[basic] or [trial].")
       }
       setting 'xpack.security.enabled', 'true'
-      setting 'xpack.monitoring.enabled', 'true'
-      setting 'xpack.sql.enabled', 'true'
-      setting 'xpack.rollup.enabled', 'true'
       keystore 'bootstrap.password', 'password'
       user username: 'elastic-admin', password: 'elastic-password', role: 'superuser'
     }

docs/reference/migration/migrate_8_0/settings.asciidoc

@@ -51,3 +51,21 @@ setting `cluster.remote.connect` is removed.
 In Elasticsearch 7.8.0, the setting `node.local_storage` was deprecated and
 beginning in Elasticsearch 8.0.0 all nodes will require local storage. Therefore,
 the `node.local_storage` setting has been removed.
+
+[float]
+==== Option to disable basic license features is deprecated
+
+In Elasticsearch 7.8.0, the following settings have been deprecated:
+
+* `xpack.enrich.enabled`
+* `xpack.flattened.enabled`
+* `xpack.ilm.enabled`
+* `xpack.monitoring.enabled`
+* `xpack.rollup.enabled`
+* `xpack.slm.enabled`
+* `xpack.sql.enabled`
+* `xpack.transform.enabled`
+* `xpack.vectors.enabled`
+
+In future releases, it will not be possible to disable the APIs for Enrichment,
+Flattened mappings, ILM, Monitoring, Rollup, SLM, SQL, Transforms, and Vectors.

docs/reference/modules/node.asciidoc

@@ -52,10 +52,9 @@ fails to start.
 
 <<transform-node,{transform-cap} node>>::
 
-A node that has `xpack.transform.enabled` and `node.transform` set to `true`. If
-you want to use {transforms}, there must be at least one {transform} node in
-your cluster. For more information, see <<transform-settings>> and
-<<transforms>>.
+A node that has `node.transform` set to `true`. If you want to use {transforms},
+there must be at least one {transform} node in your cluster. For more
+information, see <<transform-settings>> and <<transforms>>.
 
 [NOTE]
 [[coordinating-node]]
@@ -126,8 +125,7 @@ node.ingest: false <4>
 node.ml: false <5>
 xpack.ml.enabled: true <6>
 node.transform: false <7>
-xpack.transform.enabled: true <8>
-node.remote_client_client: false <9>
+node.remote_client_client: false <8>
 -------------------
 <1> The `node.master` role is enabled by default.
 <2> The `node.voting_only` role is disabled by default.
@@ -136,8 +134,7 @@ node.remote_client_client: false <9>
 <5> Disable the `node.ml` role (enabled by default).
 <6> The `xpack.ml.enabled` setting is enabled by default.
 <7> Disable the `node.transform` role.
-<8> The `xpack.transform.enabled` setting is enabled by default.
-<9> Disable remote cluster connections (enabled by default).
+<8> Disable remote cluster connections (enabled by default).
 
 To create a dedicated master-eligible node in the {oss-dist}, set:
 
@@ -209,8 +206,7 @@ node.ingest: false <4>
 node.ml: false <5>
 xpack.ml.enabled: true <6>
 node.transform: false <7>
-xpack.transform.enabled: true <8>
-node.remote_cluster_client: false <9>
+node.remote_cluster_client: false <8>
 -------------------
 <1> The `node.master` role is enabled by default.
 <2> Enable the `node.voting_only` role (disabled by default).
@@ -219,8 +215,7 @@ node.remote_cluster_client: false <9>
 <5> Disable the `node.ml` role (enabled by default).
 <6> The `xpack.ml.enabled` setting is enabled by default.
 <7> Disable the `node.transform` role.
-<8> The `xpack.transform.enabled` setting is enabled by default.
-<9> Disable remote cluster connections (enabled by default).
+<8> Disable remote cluster connections (enabled by default).
 
 [float]
 [[data-node]]
@@ -243,17 +238,15 @@ node.data: true <3>
 node.ingest: false <4>
 node.ml: false <5>
 node.transform: false <6>
-xpack.transform.enabled: true <7>
-node.remote_cluster_client: false <8>
+node.remote_cluster_client: false <7>
 -------------------
 <1> Disable the `node.master` role (enabled by default).
 <2> The `node.voting_only` role is disabled by default.
 <3> The `node.data` role is enabled by default.
 <4> Disable the `node.ingest` role (enabled by default).
 <5> Disable the `node.ml` role (enabled by default).
 <6> Disable the `node.transform` role.
-<7> The `xpack.transform.enabled` setting is enabled by default.
-<8> Disable remote cluster connections (enabled by default).
+<7> Disable remote cluster connections (enabled by default).
 
 To create a dedicated data node in the {oss-dist}, set:
 [source,yaml]
@@ -343,8 +336,7 @@ node.ingest: false <4>
 node.ml: false <5>
 xpack.ml.enabled: true <6>
 node.transform: false <7>
-xpack.transform.enabled: true <8>
-node.remote_cluster_client: false <9>
+node.remote_cluster_client: false <8>
 -------------------
 <1> Disable the `node.master` role (enabled by default).
 <2> The `node.voting_only` role is disabled by default.
@@ -353,8 +345,7 @@ node.remote_cluster_client: false <9>
 <5> Disable the `node.ml` role (enabled by default).
 <6> The `xpack.ml.enabled` setting is enabled by default.
 <7> Disable the `node.transform` role.
-<8> The `xpack.transform.enabled` setting is enabled by default.
-<9> Disable remote cluster connections (enabled by default).
+<8> Disable remote cluster connections (enabled by default).
 
 To create a dedicated coordinating node in the {oss-dist}, set:
 
@@ -396,8 +387,7 @@ node.ingest: false <4>
 node.ml: true <5>
 xpack.ml.enabled: true <6>
 node.transform: false <7>
-xpack.transform.enabled: true <8>
-node.remote_cluster_client: false <9>
+node.remote_cluster_client: false <8>
 -------------------
 <1> Disable the `node.master` role (enabled by default).
 <2> The `node.voting_only` role is disabled by default.
@@ -406,22 +396,21 @@ node.remote_cluster_client: false <9>
 <5> The `node.ml` role is enabled by default.
 <6> The `xpack.ml.enabled` setting is enabled by default.
 <7> Disable the `node.transform` role.
-<8> The `xpack.transform.enabled` setting is enabled by default.
-<9> Disable remote cluster connections (enabled by default).
+<8> Disable remote cluster connections (enabled by default).
 
 [discrete]
 [[transform-node]]
 === [xpack]#{transform-cap} node#
 
 {transform-cap} nodes run {transforms} and handle {transform} API requests.
 
-If you want to use {transforms} in your cluster, you must have
-`xpack.transform.enabled` set to `true` on all master-eligible nodes and all
-data nodes. If you want to use {transforms} in clients (including {kib}), it
-must also be enabled on all coordinating nodes. You must also have
-`node.transform` set to `true` on at least one node. This is the default
-behavior. If you have the {oss-dist}, do not use these settings. For more
-information, see <<transform-settings>>.
+If you want to use {transforms} in your cluster, you must not have
+`xpack.transform.enabled` set to `false` on any master-eligible or data
+nodes. To use {transforms} in clients (including {kib}), do not disable this
+setting on any coordinating nodes. You must also have `node.transform` set to
+`true` on at least one node. This is the default behavior. If you have the
+{oss-dist}, do not use these settings. For more information, see
+<<transform-settings>>.
 
 To create a dedicated {transform} node in the {default-dist}, set:
 
@@ -433,17 +422,15 @@ node.data: false <3>
 node.ingest: false <4>
 node.ml: false <5>
 node.transform: true <6>
-xpack.transform.enabled: true <7>
-node.remote_cluster_client: false <8>
+node.remote_cluster_client: false <7>
 -------------------
 <1> Disable the `node.master` role.
 <2> Disable the `node.voting_only`.
 <3> Disable the `node.data` role.
 <4> Disable the `node.ingest` role.
 <5> Disable the `node.ml` role.
 <6> Enable the `node.transform` role.
-<7> Enable the `xpack.transform.enabled` setting.
-<8> Disable remote cluster connections.
+<7> Disable remote cluster connections.
 
 [float]
 [[change-node-role]]

docs/reference/monitoring/collecting-monitoring-data.asciidoc

@@ -30,8 +30,8 @@ To learn about monitoring in general, see <<monitor-elasticsearch-cluster>>.
 
 . Configure your cluster to collect monitoring data:
 
-.. Verify that the `xpack.monitoring.enabled` setting is `true`, which is its
-default value, on each node in the cluster. For more information, see
+.. Verify that the deprecated `xpack.monitoring.enabled` setting is not set to
+`false` on any node in the cluster. For more information, see
 <<monitoring-settings>>.
 
 .. Verify that the `xpack.monitoring.elasticsearch.collection.enabled` setting

docs/reference/settings/ilm-settings.asciidoc

@@ -7,8 +7,9 @@ These are the settings available for configuring Index Lifecycle Management
 ==== Cluster level settings
 
 `xpack.ilm.enabled`::
-Whether ILM is enabled or disabled, setting this to `false` disables any
-ILM REST API endpoints and functionality. Defaults to `true`.
+deprecated:[7.8.0,Basic License features should always be enabled] +
+Whether ILM is enabled or disabled, setting this to `false` disables any ILM
+REST API endpoints and functionality. Defaults to `true`.
 
 `indices.lifecycle.poll_interval`::
 (<<time-units, time units>>) How often {ilm} checks for indices that meet policy

docs/reference/settings/monitoring-settings.asciidoc

@@ -27,6 +27,7 @@ For more information, see <<monitor-elasticsearch-cluster>>.
 ==== General Monitoring Settings
 
 `xpack.monitoring.enabled`::
+deprecated:[7.8.0,Basic License features should always be enabled] +
 Set to `true` (default) to enable {es} {monitoring} for {es} on the node.
 +
 --

docs/reference/settings/notification-settings.asciidoc

@@ -38,13 +38,12 @@ required. For more information, see <<encrypting-data>>.
 added:[6.3.0,Default changed to `true`.]
 deprecated:[7.0.0,Watcher history indices are now managed by the `watch-history-ilm-policy` ILM policy]
 +
-Set to `true` (default) to enable the cleaner service. If this setting is
-`true`, the `xpack.monitoring.enabled` setting must also be set to `true` with
-a local exporter enabled. The cleaner service removes previous versions of
-{watcher} indices (for example, `.watcher-history*`) when it determines that
-they are old. The duration of {watcher} indices is determined by the
-`xpack.monitoring.history.duration` setting, which defaults to 7 days. For
-more information about that setting, see <<monitoring-settings>>.
+Set to `true` (default) to enable the cleaner service. The cleaner service
+removes previous versions of {watcher} indices (for example,
+`.watcher-history*`) when it determines that they are old. The duration of
+{watcher} indices is determined by the `xpack.monitoring.history.duration`
+setting, which defaults to 7 days. For more information about that setting,
+see <<monitoring-settings>>.
 
 `xpack.http.proxy.host`::
 Specifies the address of the proxy server to use to connect to HTTP services.

docs/reference/settings/sql-settings.asciidoc

@@ -12,4 +12,5 @@ these SQL Access settings in the `elasticsearch.yml` file.
 [[general-sql-settings]]
 ==== General SQL Access Settings
 `xpack.sql.enabled`::
+deprecated:[7.8.0,Basic License features should always be enabled] +
 Set to `false` to disable SQL Access on the node.

docs/reference/settings/transform-settings.asciidoc

@@ -35,13 +35,14 @@ of transforms to certain nodes instead of using `xpack.transform.enabled`. On de
 coordinating nodes or dedicated master nodes, disable the node.transform role.
 
 `xpack.transform.enabled`::
-Set to `true` (default) to enable {transforms} on the node. +
+deprecated:[7.8.0,Basic License features should always be enabled] +
+Set to `true` (default) to enable {transforms} on the node.
 +
 If set to `false` in `elasticsearch.yml`, the {transform} APIs are disabled on
 the node. Therefore the node cannot start or administrate {transforms} or
 receive transport (internal) communication requests related to {transform} APIs.
 If the node is a coordinating node, {transform} requests from clients (including
-{kib}) also fail. 
+{kib}) also fail.
 +
 IMPORTANT: If you want to use {transform} features in your cluster, it is
 recommended that you set `xpack.transform.enabled` to `true` on all nodes. This

docs/reference/slm/apis/index.asciidoc

@@ -3,33 +3,32 @@
 [[snapshot-lifecycle-management]]
 == Manage the snapshot lifecycle
 
-You can set up snapshot lifecycle policies to automate the timing, frequency, and retention of snapshots. 
-Snapshot policies can apply to multiple indices. 
+You can set up snapshot lifecycle policies to automate the timing, frequency, and retention of snapshots.
+Snapshot policies can apply to multiple indices.
 
 The snapshot lifecycle management (SLM) <<snapshot-lifecycle-management-api, CRUD APIs>> provide
-the building blocks for the snapshot policy features that are part of the Management application in {kib}. 
-The  Snapshot and Restore UI makes it easy to set up policies, register snapshot repositories, 
+the building blocks for the snapshot policy features that are part of the Management application in {kib}.
+The  Snapshot and Restore UI makes it easy to set up policies, register snapshot repositories,
 view and manage snapshots, and restore indices.
 
 You can stop and restart SLM to temporarily pause automatic backups while performing
 upgrades or other maintenance.
-To disable SLM entirely, set `xpack.slm.enabled` to `false` in `elasticsearch.yml`.
 
 [float]
 [[slm-and-security]]
 === Security and SLM
 
-Two built-in cluster privileges control access to the SLM actions when 
+Two built-in cluster privileges control access to the SLM actions when
 {es} {security-features} are enabled:
 
-`manage_slm`:: Allows a user to perform all SLM actions, including creating and updating policies 
-and starting and stopping SLM. 
+`manage_slm`:: Allows a user to perform all SLM actions, including creating and updating policies
+and starting and stopping SLM.
 
-`read_slm`:: Allows a user to perform all read-only SLM actions, 
+`read_slm`:: Allows a user to perform all read-only SLM actions,
 such as getting policies and checking the SLM status.
 
 `cluster:admin/snapshot/*`:: Allows a user to take and delete snapshots of any
-index, whether or not they have access to that index. 
+index, whether or not they have access to that index.
 
 For example, the following request configures an `slm-admin` role that grants the privileges
 necessary for administering SLM.
@@ -69,4 +68,4 @@ POST /_security/role/slm-read-only
 
 include::getting-started-slm.asciidoc[]
 
-include::slm-retention.asciidoc[]
+include::slm-retention.asciidoc[]