Skip to content

Commit 718a791

Browse files
committed
remove TODO
1 parent 70ecab5 commit 718a791

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

server/src/main/java/org/elasticsearch/search/SearchHits.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public final class SearchHits implements Streamable, ToXContentFragment, Iterabl
4747

4848
public static SearchHits empty() {
4949
// We shouldn't use static final instance, since that could directly be returned by native transport clients
50-
return new SearchHits(EMPTY, new TotalHits(0, Relation.EQUAL_TO), 0, null, null, null);
50+
return new SearchHits(EMPTY, new TotalHits(0, Relation.EQUAL_TO), 0);
5151
}
5252

5353
public static final SearchHit[] EMPTY = new SearchHit[0];
@@ -69,10 +69,6 @@ public static SearchHits empty() {
6969

7070
}
7171

72-
//TODO look for other users of the old constructor!!!
73-
74-
//TODO we may want to remove this constructor and replace it with the new one:
75-
// such change causes a lot of noise, probably wise to make it as a followup
7672
public SearchHits(SearchHit[] hits, @Nullable TotalHits totalHits, float maxScore) {
7773
this(hits, totalHits, maxScore, null, null, null);
7874
}

0 commit comments

Comments
 (0)