Fix slow assertion running in production in RoutingNodes (#88951)

original-brownbear · web-flow · commit 713657f11806 · 2022-07-29T22:37:09.000+02:00
This needs to be in a separate method, it's currently running in production and uses significant CPU time. Broken in #88794
diff --git a/server/src/main/java/org/elasticsearch/cluster/routing/RoutingNodes.java b/server/src/main/java/org/elasticsearch/cluster/routing/RoutingNodes.java
@@ -146,7 +146,12 @@ private RoutingNodes(RoutingTable routingTable, DiscoveryNodes discoveryNodes, b
                 }
             }
         }
+        assert invariant();
+    }
+
+    private boolean invariant() {
         nodesToShards.values().forEach(RoutingNode::invariant);
+        return true;
     }
 
     private RoutingNodes(RoutingNodes routingNodes) {

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,12 @@ private RoutingNodes(RoutingTable routingTable, DiscoveryNodes discoveryNodes, b`
`146`	`146`	`}`
`147`	`147`	`}`
`148`	`148`	`}`
	`149`	`+ assert invariant();`
	`150`	`+ }`
	`151`	`+`
	`152`	`+ private boolean invariant() {`
`149`	`153`	`nodesToShards.values().forEach(RoutingNode::invariant);`
	`154`	`+ return true;`
`150`	`155`	`}`
`151`	`156`
`152`	`157`	`private RoutingNodes(RoutingNodes routingNodes) {`