Do not inject MigrateAction if it is not supported (#89457)

In #61377 we introduced a feature to let ILM migrate data between tiers.
We achived this by inject a MigrateAction in `warm` and `cold` phase.
However we also injected this action to phases where it is not supported
such as `hot`, `frozen` and `delete` phase. It's better to no inject
MigrateAction even though MigrateAction in these phases will be filtered
out in `TimeseriesLifecycleType#getOrderedActions(Phase)` . This pr
updates the
`TimeseriesLifecycleType#shouldInjectMigrateStepForPhase(Phase)` to not
inject MigrateAction for phase in which MigrateAction is not supported.

Author: mushao999

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/TimeseriesLifecycleType.java

@@ -154,11 +154,20 @@ public List<Phase> getOrderedPhases(Map<String, Phase> phases) {
     }
 
     public static boolean shouldInjectMigrateStepForPhase(Phase phase) {
+        if (ALLOWED_ACTIONS.containsKey(phase.getName()) == false) {
+            return false;
+        }
+
         // searchable snapshots automatically set their own allocation rules, no need to configure them with a migrate step.
         if (phase.getActions().get(SearchableSnapshotAction.NAME) != null) {
             return false;
         }
 
+        // do not inject if MigrateAction is not supported for this phase (such as hot, frozen, delete phase)
+        if (ALLOWED_ACTIONS.get(phase.getName()).contains(MigrateAction.NAME) == false) {
+            return false;
+        }
+
         // if the user configured the {@link MigrateAction} already we won't automatically configure it
         if (phase.getActions().get(MigrateAction.NAME) != null) {
             return false;

x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/TimeseriesLifecycleTypeTests.java

@@ -843,6 +843,29 @@ public void testShouldMigrateDataToTiers() {
             assertThat(TimeseriesLifecycleType.shouldInjectMigrateStepForPhase(phase), is(false));
         }
 
+        {
+            // not inject in hot phase
+            Phase phase = new Phase(HOT_PHASE, TimeValue.ZERO, Collections.emptyMap());
+            assertThat(TimeseriesLifecycleType.shouldInjectMigrateStepForPhase(phase), is(false));
+        }
+
+        {
+            // not inject in frozen phase
+            Phase phase = new Phase(FROZEN_PHASE, TimeValue.ZERO, Collections.emptyMap());
+            assertThat(TimeseriesLifecycleType.shouldInjectMigrateStepForPhase(phase), is(false));
+        }
+
+        {
+            // not inject in delete phase
+            Phase phase = new Phase(DELETE_PHASE, TimeValue.ZERO, Collections.emptyMap());
+            assertThat(TimeseriesLifecycleType.shouldInjectMigrateStepForPhase(phase), is(false));
+        }
+
+        {
+            // return false for invalid phase
+            Phase phase = new Phase(HOT_PHASE + randomAlphaOfLength(5), TimeValue.ZERO, Collections.emptyMap());
+            assertThat(TimeseriesLifecycleType.shouldInjectMigrateStepForPhase(phase), is(false));
+        }
     }
 
     public void testValidatingSearchableSnapshotRepos() {