Remove groovy scripting language (#21607)

* Scripting: Remove groovy scripting language

Groovy was deprecated in 5.0. This change removes it, along with the
legacy default language infrastructure in scripting.

Author: rjernst

core/src/main/java/org/elasticsearch/index/query/QueryRewriteContext.java

@@ -113,15 +113,6 @@ public QueryParseContext newParseContext(XContentParser parser) {
         return new QueryParseContext(indicesQueriesRegistry, parser, indexSettings.getParseFieldMatcher());
     }
 
-    /**
-     * Returns a new {@link QueryParseContext} like {@link #newParseContext(XContentParser)} with the only diffence, that
-     * the default script language will default to what has been set in the 'script.legacy.default_lang' setting.
-     */
-    public QueryParseContext newParseContextWithLegacyScriptLanguage(XContentParser parser) {
-        String defaultScriptLanguage = ScriptSettings.getLegacyDefaultLang(indexSettings.getNodeSettings());
-        return new QueryParseContext(defaultScriptLanguage, indicesQueriesRegistry, parser, indexSettings.getParseFieldMatcher());
-    }
-
     public long nowInMillis() {
         return nowInMillis.getAsLong();
     }

core/src/main/java/org/elasticsearch/script/ScriptSettings.java

@@ -32,17 +32,6 @@
 
 public class ScriptSettings {
 
-    static final String LEGACY_DEFAULT_LANG = "groovy";
-
-    /**
-     * The default script language to use for scripts that are stored in documents that have no script lang set explicitly.
-     * This setting is legacy setting and only applies for indices created on ES versions prior to version 5.0
-     *
-     * This constant will be removed in the next major release.
-     */
-    @Deprecated
-    public static final String LEGACY_SCRIPT_SETTING = "script.legacy.default_lang";
-
     private static final Map<ScriptType, Setting<Boolean>> SCRIPT_TYPE_SETTING_MAP;
 
     static {
@@ -58,21 +47,13 @@ public class ScriptSettings {
 
     private final Map<ScriptContext, Setting<Boolean>> scriptContextSettingMap;
     private final List<Setting<Boolean>> scriptLanguageSettings;
-    private final Setting<String> defaultLegacyScriptLanguageSetting;
 
     public ScriptSettings(ScriptEngineRegistry scriptEngineRegistry, ScriptContextRegistry scriptContextRegistry) {
         Map<ScriptContext, Setting<Boolean>> scriptContextSettingMap = contextSettings(scriptContextRegistry);
         this.scriptContextSettingMap = Collections.unmodifiableMap(scriptContextSettingMap);
 
         List<Setting<Boolean>> scriptLanguageSettings = languageSettings(SCRIPT_TYPE_SETTING_MAP, scriptContextSettingMap, scriptEngineRegistry, scriptContextRegistry);
         this.scriptLanguageSettings = Collections.unmodifiableList(scriptLanguageSettings);
-
-        this.defaultLegacyScriptLanguageSetting = new Setting<>(LEGACY_SCRIPT_SETTING, LEGACY_DEFAULT_LANG, setting -> {
-            if (!LEGACY_DEFAULT_LANG.equals(setting) && !scriptEngineRegistry.getRegisteredLanguages().containsKey(setting)) {
-                throw new IllegalArgumentException("unregistered default language [" + setting + "]");
-            }
-            return setting;
-        }, Property.NodeScope);
     }
 
     private static Map<ScriptContext, Setting<Boolean>> contextSettings(ScriptContextRegistry scriptContextRegistry) {
@@ -169,19 +150,10 @@ public List<Setting<?>> getSettings() {
         settings.addAll(SCRIPT_TYPE_SETTING_MAP.values());
         settings.addAll(scriptContextSettingMap.values());
         settings.addAll(scriptLanguageSettings);
-        settings.add(defaultLegacyScriptLanguageSetting);
         return settings;
     }
 
     public Iterable<Setting<Boolean>> getScriptLanguageSettings() {
         return scriptLanguageSettings;
     }
-
-    public Setting<String> getDefaultLegacyScriptLanguageSetting() {
-        return defaultLegacyScriptLanguageSetting;
-    }
-
-    public static String getLegacyDefaultLang(Settings settings) {
-        return settings.get(LEGACY_SCRIPT_SETTING, ScriptSettings.LEGACY_DEFAULT_LANG);
-    }
 }

core/src/test/java/org/elasticsearch/index/query/QueryDSLDocumentationTests.java

@@ -297,7 +297,7 @@ public void testScript() {
         parameters.put("param1", 5);
         scriptQuery(
                 new Script(
-                    ScriptType.FILE, "groovy", "mygroovyscript",
+                    ScriptType.FILE, "coollang", "myscript",
                     parameters)
             );
 

core/src/test/java/org/elasticsearch/index/query/QueryRewriteContextTests.java

@@ -221,7 +221,7 @@ public void testDefaultBehaviourFineGrainedSettings() throws IOException {
             builder.put("script.file", "true");
         }
         buildScriptService(builder.build());
-        createFileScripts("groovy", "mustache", "dtest");
+        createFileScripts("mustache", "dtest");
 
         for (ScriptContext scriptContext : scriptContexts) {
             // only file scripts are accepted by default
@@ -292,7 +292,7 @@ public void testFineGrainedSettings() throws IOException {
         }
 
         buildScriptService(builder.build());
-        createFileScripts("groovy", "expression", "mustache", "dtest");
+        createFileScripts("expression", "mustache", "dtest");
 
         for (ScriptType scriptType : ScriptType.values()) {
             //make sure file scripts have a different name than inline ones.

core/src/test/java/org/elasticsearch/script/ScriptServiceTests.java

@@ -34,39 +34,6 @@
 
 public class ScriptSettingsTests extends ESTestCase {
 
-    public void testDefaultLegacyLanguageIsPainless() {
-        ScriptEngineRegistry scriptEngineRegistry =
-                new ScriptEngineRegistry(Collections.singletonList(new CustomScriptEngineService()));
-        ScriptContextRegistry scriptContextRegistry = new ScriptContextRegistry(Collections.emptyList());
-        ScriptSettings scriptSettings = new ScriptSettings(scriptEngineRegistry, scriptContextRegistry);
-        assertThat(scriptSettings.getDefaultLegacyScriptLanguageSetting().get(Settings.EMPTY),
-                equalTo(ScriptSettings.LEGACY_DEFAULT_LANG));
-    }
-
-    public void testCustomLegacyDefaultLanguage() {
-        ScriptEngineRegistry scriptEngineRegistry =
-            new ScriptEngineRegistry(Collections.singletonList(new CustomScriptEngineService()));
-        ScriptContextRegistry scriptContextRegistry = new ScriptContextRegistry(Collections.emptyList());
-        ScriptSettings scriptSettings = new ScriptSettings(scriptEngineRegistry, scriptContextRegistry);
-        String defaultLanguage = CustomScriptEngineService.NAME;
-        Settings settings = Settings.builder().put(ScriptSettings.LEGACY_SCRIPT_SETTING, defaultLanguage).build();
-        assertThat(scriptSettings.getDefaultLegacyScriptLanguageSetting().get(settings), equalTo(defaultLanguage));
-    }
-
-    public void testInvalidLegacyDefaultLanguage() {
-        ScriptEngineRegistry scriptEngineRegistry =
-            new ScriptEngineRegistry(Collections.singletonList(new CustomScriptEngineService()));
-        ScriptContextRegistry scriptContextRegistry = new ScriptContextRegistry(Collections.emptyList());
-        ScriptSettings scriptSettings = new ScriptSettings(scriptEngineRegistry, scriptContextRegistry);
-        Settings settings = Settings.builder().put(ScriptSettings.LEGACY_SCRIPT_SETTING, "C++").build();
-        try {
-            scriptSettings.getDefaultLegacyScriptLanguageSetting().get(settings);
-            fail("should have seen unregistered default language");
-        } catch (IllegalArgumentException e) {
-            assertThat(e.getMessage(), containsString("unregistered default language [C++]"));
-        }
-    }
-
     public void testSettingsAreProperlyPropogated() {
         ScriptEngineRegistry scriptEngineRegistry =
             new ScriptEngineRegistry(Collections.singletonList(new CustomScriptEngineService()));

core/src/test/java/org/elasticsearch/script/ScriptSettingsTests.java

@@ -5,21 +5,6 @@ Here is how you can use
 {ref}/search-aggregations-metrics-scripted-metric-aggregation.html[Scripted Metric Aggregation]
 with Java API.
 
-Don't forget to add Groovy in your classpath if you want to run Groovy scripts in an embedded data node
-(for unit tests for example).
-For example, with Maven, add this dependency to your `pom.xml` file:
-
-[source,xml]
---------------------------------------------------
-<dependency>
-    <groupId>org.codehaus.groovy</groupId>
-    <artifactId>groovy-all</artifactId>
-    <version>2.3.2</version>
-    <classifier>indy</classifier>
-</dependency>
---------------------------------------------------
-
-
 ===== Prepare aggregation request
 
 Here is an example on how to create the aggregation request:

docs/java-api/aggregations/metrics/scripted-metric-aggregation.asciidoc

@@ -153,7 +153,6 @@ If everything goes well, you should see a bunch of messages that look like below
 [2016-09-16T14:17:51,967][INFO ][o.e.p.PluginsService     ] [6-bjhwl] loaded module [aggs-matrix-stats]
 [2016-09-16T14:17:51,967][INFO ][o.e.p.PluginsService     ] [6-bjhwl] loaded module [ingest-common]
 [2016-09-16T14:17:51,967][INFO ][o.e.p.PluginsService     ] [6-bjhwl] loaded module [lang-expression]
-[2016-09-16T14:17:51,967][INFO ][o.e.p.PluginsService     ] [6-bjhwl] loaded module [lang-groovy]
 [2016-09-16T14:17:51,967][INFO ][o.e.p.PluginsService     ] [6-bjhwl] loaded module [lang-mustache]
 [2016-09-16T14:17:51,967][INFO ][o.e.p.PluginsService     ] [6-bjhwl] loaded module [lang-painless]
 [2016-09-16T14:17:51,967][INFO ][o.e.p.PluginsService     ] [6-bjhwl] loaded module [percolator]

docs/reference/getting-started.asciidoc

@@ -33,6 +33,7 @@ way to reindex old indices is to use the `reindex` API.
 * <<breaking_60_settings_changes>>
 * <<breaking_60_plugins_changes>>
 * <<breaking_60_indices_changes>>
+* <<breaking_60_scripting_changes>>
 
 include::migrate_6_0/cat.asciidoc[]
 
@@ -51,3 +52,5 @@ include::migrate_6_0/settings.asciidoc[]
 include::migrate_6_0/plugins.asciidoc[]
 
 include::migrate_6_0/indices.asciidoc[]
+
+include::migrate_6_0/scripting.asciidoc[]

docs/reference/migration/migrate_6_0.asciidoc

@@ -0,0 +1,7 @@
+[[breaking_60_scripting_changes]]
+=== Scripting changes
+
+==== Groovy language removed
+
+The groovy scripting language was deprecated in elasticsearch 5.0 and is now removed.
+Use painless instead.