Rest test fixes (#27354)

* REST: Rename ingest.processor.grok to ingest.processor_grok
* REST: Rename remote.info to cluster.remote_info
* REST: Fixed bad YAML comments
* REST: Force dummy scripts to be strings, not numbers
* REST: Fix bad YAML in search/110_field_collapsing.yml
* REST: Adjust percentile tests to work with Perl number handling

Author: clintongormley

modules/ingest-common/src/test/resources/rest-api-spec/test/ingest/120_grok.yml

@@ -158,6 +158,6 @@ teardown:
 ---
 "Test Grok Patterns Retrieval":
   - do:
-      ingest.processor.grok: {}
+      ingest.processor_grok: {}
   - length: { patterns: 303 }
   - match: { patterns.PATH: "(?:%{UNIXPATH}|%{WINPATH})" }

qa/mixed-cluster/src/test/resources/rest-api-spec/test/10_parent_child.yml

@@ -48,5 +48,5 @@
 # This suite is not needed for testing mixed clusters with minimum version 6.0.0 and higher,
 # because join type should be used instead of _parent field.
   - do:
-      remote.info: {}
+      cluster.remote_info: {}
   - is_true: ''

qa/multi-cluster-search/src/test/resources/rest-api-spec/test/multi_cluster/20_info.yml

@@ -2,7 +2,7 @@
 "Fetch remote cluster info for existing cluster":
 
   - do:
-      remote.info: {}
+      cluster.remote_info: {}
   - match: { my_remote_cluster.connected: true }
   - match: { my_remote_cluster.num_nodes_connected: 1}
   - match: { my_remote_cluster.max_connections_per_cluster: 1}
@@ -37,7 +37,7 @@
   - match: { hits.hits.0._index: "test_remote_cluster:test_index" }
 
   - do:
-      remote.info: {}
+      cluster.remote_info: {}
   - set: { my_remote_cluster.http_addresses.0: remote_http }
   - match: { test_remote_cluster.http_addresses.0: $remote_http }
 

rest-api-spec/src/main/resources/rest-api-spec/api/remote.info.json renamed to rest-api-spec/src/main/resources/rest-api-spec/api/cluster.remote_info.json

@@ -1,5 +1,5 @@
 {
-  "remote.info": {
+  "cluster.remote_info": {
     "documentation": "http://www.elastic.co/guide/en/elasticsearch/reference/master/cluster-remote-info.html",
     "methods": ["GET"],
     "url": {
@@ -9,4 +9,4 @@
     },
     "body": null
   }
-}
+}

rest-api-spec/src/main/resources/rest-api-spec/api/ingest.processor.grok.json renamed to rest-api-spec/src/main/resources/rest-api-spec/api/ingest.processor_grok.json

@@ -1,5 +1,5 @@
 {
-  "ingest.processor.grok": {
+  "ingest.processor_grok": {
     "documentation": "https://www.elastic.co/guide/en/elasticsearch/plugins/master/ingest.html",
     "methods": [ "GET" ],
     "url": {

rest-api-spec/src/main/resources/rest-api-spec/test/remote.info/10_info.yml renamed to rest-api-spec/src/main/resources/rest-api-spec/test/cluster.remote_info/10_info.yml

@@ -4,6 +4,6 @@
       version: " - 5.3.99"
       reason: this API doesn't exist in 5.3.x yet
   - do:
-      remote.info: {}
+      cluster.remote_info: {}
   - is_true: ''
 

rest-api-spec/src/main/resources/rest-api-spec/test/indices.exists_type/10_basic.yml

@@ -1,7 +1,8 @@
 ---
 "Exists type":
  - skip:
-    version: "5.99.99 - "# this will only run in a mixed cluster environment with at least 1 5.x node
+    # this will only run in a mixed cluster environment with at least 1 5.x node
+    version: "5.99.99 - "
     reason:  multiple types are not supported on 6.x indices onwards
 
  - do:

rest-api-spec/src/main/resources/rest-api-spec/test/indices.get_mapping/70_legacy_multi_type.yml

@@ -2,7 +2,8 @@
 setup:
 
   - skip:
-        version: "5.99.99 - " # this will only run in a mixed cluster environment with at least 1 5.x node
+        # this will only run in a mixed cluster environment with at least 1 5.x node
+        version: "5.99.99 - " 
         reason:  multiple types are not supported on 6.x indices onwards
 
   - do:

rest-api-spec/src/main/resources/rest-api-spec/test/indices.rollover/10_basic.yml

@@ -17,8 +17,9 @@
         type:  test
         id:    "1"
         body:  { "foo": "hello world" }
-        refresh: true # make this doc visible in index stats
-
+        # make this doc visible in index stats
+        refresh: true
+ 
   - do:
       get:
         index: logs_search

rest-api-spec/src/main/resources/rest-api-spec/test/mget/15_ids.yml

@@ -1,7 +1,8 @@
 ---
 "IDs":
   - skip:
-        version: "5.99.99 - "# this will only run in a mixed cluster environment with at least 1 5.x node
+        # this will only run in a mixed cluster environment with at least 1 5.x node
+        version: "5.99.99 - "
         reason:  multiple types are not supported on 6.x indices onwards
 
   - do: