[CCR] Removed custom follow and unfollow api's reponse classes with AcknowledgedResponse (#33260)

martijnvg · web-flow · commit 66b164c2a617 · 2018-08-31T21:16:06.000+07:00
These response classes did not add any value and in that case just AcknowledgedResponse should be used.

I also changed the formatting of methods to take one line per parameter in
FollowIndexAction.java and UnfollowIndexAction.java files to make
reviewing diffs in the future easier.
diff --git a/x-pack/plugin/ccr/src/main/java/org/elasticsearch/xpack/ccr/action/FollowIndexAction.java b/x-pack/plugin/ccr/src/main/java/org/elasticsearch/xpack/ccr/action/FollowIndexAction.java
@@ -62,7 +62,7 @@
 import java.util.concurrent.atomic.AtomicReferenceArray;
 import java.util.stream.Collectors;
 
-public class FollowIndexAction extends Action<FollowIndexAction.Response> {
+public class FollowIndexAction extends Action<AcknowledgedResponse> {
 
     public static final FollowIndexAction INSTANCE = new FollowIndexAction();
     public static final String NAME = "cluster:admin/xpack/ccr/follow_index";
@@ -72,8 +72,8 @@ private FollowIndexAction() {
     }
 
     @Override
-    public Response newResponse() {
-        return new Response();
+    public AcknowledgedResponse newResponse() {
+        return new AcknowledgedResponse();
     }
 
     public static class Request extends ActionRequest implements ToXContentObject {
@@ -129,9 +129,17 @@ public static Request fromXContent(XContentParser parser, String followerIndex)
         private TimeValue retryTimeout;
         private TimeValue idleShardRetryDelay;
 
-        public Request(String leaderIndex, String followerIndex, Integer maxBatchOperationCount, Integer maxConcurrentReadBatches,
-                       Long maxOperationSizeInBytes, Integer maxConcurrentWriteBatches, Integer maxWriteBufferSize,
-                       TimeValue retryTimeout, TimeValue idleShardRetryDelay) {
+        public Request(
+            String leaderIndex,
+            String followerIndex,
+            Integer maxBatchOperationCount,
+            Integer maxConcurrentReadBatches,
+            Long maxOperationSizeInBytes,
+            Integer maxConcurrentWriteBatches,
+            Integer maxWriteBufferSize,
+            TimeValue retryTimeout,
+            TimeValue idleShardRetryDelay) {
+
             if (leaderIndex == null) {
                 throw new IllegalArgumentException("leader_index is missing");
             }
@@ -271,22 +279,21 @@ public boolean equals(Object o) {
 
         @Override
         public int hashCode() {
-            return Objects.hash(leaderIndex, followerIndex, maxBatchOperationCount, maxConcurrentReadBatches, maxOperationSizeInBytes,
-                maxConcurrentWriteBatches, maxWriteBufferSize, retryTimeout, idleShardRetryDelay);
-        }
-    }
-
-    public static class Response extends AcknowledgedResponse {
-
-        Response() {
-        }
-
-        Response(boolean acknowledged) {
-            super(acknowledged);
+            return Objects.hash(
+                leaderIndex,
+                followerIndex,
+                maxBatchOperationCount,
+                maxConcurrentReadBatches,
+                maxOperationSizeInBytes,
+                maxConcurrentWriteBatches,
+                maxWriteBufferSize,
+                retryTimeout,
+                idleShardRetryDelay
+            );
         }
     }
 
-    public static class TransportAction extends HandledTransportAction<Request, Response> {
+    public static class TransportAction extends HandledTransportAction<Request, AcknowledgedResponse> {
 
         private final Client client;
         private final ThreadPool threadPool;
@@ -318,7 +325,9 @@ public TransportAction(
         }
 
         @Override
-        protected void doExecute(final Task task, final Request request, final ActionListener<Response> listener) {
+        protected void doExecute(final Task task,
+                                 final Request request,
+                                 final ActionListener<AcknowledgedResponse> listener) {
             if (ccrLicenseChecker.isCcrAllowed()) {
                 final String[] indices = new String[]{request.leaderIndex};
                 final Map<String, List<String>> remoteClusterIndices = remoteClusterService.groupClusterIndices(indices, s -> false);
@@ -337,7 +346,8 @@ protected void doExecute(final Task task, final Request request, final ActionLis
             }
         }
 
-        private void followLocalIndex(final Request request, final ActionListener<Response> listener) {
+        private void followLocalIndex(final Request request,
+                                      final ActionListener<AcknowledgedResponse> listener) {
             final ClusterState state = clusterService.state();
             final IndexMetaData followerIndexMetadata = state.getMetaData().index(request.getFollowerIndex());
             // following an index in local cluster, so use local cluster state to fetch leader index metadata
@@ -353,7 +363,7 @@ private void followRemoteIndex(
                 final Request request,
                 final String clusterAlias,
                 final String leaderIndex,
-                final ActionListener<Response> listener) {
+                final ActionListener<AcknowledgedResponse> listener) {
             final ClusterState state = clusterService.state();
             final IndexMetaData followerIndexMetadata = state.getMetaData().index(request.getFollowerIndex());
             ccrLicenseChecker.checkRemoteClusterLicenseAndFetchLeaderIndexMetadata(
@@ -380,8 +390,13 @@ private void followRemoteIndex(
          *     <li>The leader index and follow index need to have the same number of primary shards</li>
          * </ul>
          */
-        void start(Request request, String clusterNameAlias, IndexMetaData leaderIndexMetadata, IndexMetaData followIndexMetadata,
-                   ActionListener<Response> handler) throws IOException {
+        void start(
+            Request request,
+            String clusterNameAlias,
+            IndexMetaData leaderIndexMetadata,
+            IndexMetaData followIndexMetadata,
+            ActionListener<AcknowledgedResponse> handler) throws IOException {
+
             MapperService mapperService = followIndexMetadata != null ? indicesService.createIndexMapperService(followIndexMetadata) : null;
             validate(request, leaderIndexMetadata, followIndexMetadata, mapperService);
             final int numShards = followIndexMetadata.getNumberOfShards();
@@ -429,7 +444,7 @@ void finalizeResponse() {
 
                                 if (error == null) {
                                     // include task ids?
-                                    handler.onResponse(new Response(true));
+                                    handler.onResponse(new AcknowledgedResponse(true));
                                 } else {
                                     // TODO: cancel all started tasks
                                     handler.onFailure(error);
@@ -493,7 +508,9 @@ void finalizeResponse() {
         WHITELISTED_SETTINGS = Collections.unmodifiableSet(whiteListedSettings);
     }
 
-    static void validate(Request request, IndexMetaData leaderIndex, IndexMetaData followIndex, MapperService followerMapperService) {
+    static void validate(Request request,
+                         IndexMetaData leaderIndex,
+                         IndexMetaData followIndex, MapperService followerMapperService) {
         if (leaderIndex == null) {
             throw new IllegalArgumentException("leader index [" + request.leaderIndex + "] does not exist");
         }
diff --git a/x-pack/plugin/ccr/src/main/java/org/elasticsearch/xpack/ccr/action/UnfollowIndexAction.java b/x-pack/plugin/ccr/src/main/java/org/elasticsearch/xpack/ccr/action/UnfollowIndexAction.java
@@ -28,7 +28,7 @@
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.atomic.AtomicReferenceArray;
 
-public class UnfollowIndexAction extends Action<UnfollowIndexAction.Response> {
+public class UnfollowIndexAction extends Action<AcknowledgedResponse> {
 
     public static final UnfollowIndexAction INSTANCE = new UnfollowIndexAction();
     public static final String NAME = "cluster:admin/xpack/ccr/unfollow_index";
@@ -38,8 +38,8 @@ private UnfollowIndexAction() {
     }
 
     @Override
-    public Response newResponse() {
-        return new Response();
+    public AcknowledgedResponse newResponse() {
+        return new AcknowledgedResponse();
     }
 
     public static class Request extends ActionRequest {
@@ -72,31 +72,27 @@ public void writeTo(StreamOutput out) throws IOException {
         }
     }
 
-    public static class Response extends AcknowledgedResponse {
-
-        Response(boolean acknowledged) {
-            super(acknowledged);
-        }
-
-        Response() {
-        }
-    }
-
-    public static class TransportAction extends HandledTransportAction<Request, Response> {
+    public static class TransportAction extends HandledTransportAction<Request, AcknowledgedResponse> {
 
         private final Client client;
         private final PersistentTasksService persistentTasksService;
 
         @Inject
-        public TransportAction(Settings settings, TransportService transportService,
-                               ActionFilters actionFilters, Client client, PersistentTasksService persistentTasksService) {
+        public TransportAction(Settings settings,
+                               TransportService transportService,
+                               ActionFilters actionFilters,
+                               Client client,
+                               PersistentTasksService persistentTasksService) {
             super(settings, NAME, transportService, actionFilters, Request::new);
             this.client = client;
             this.persistentTasksService = persistentTasksService;
         }
 
         @Override
-        protected void doExecute(Task task, Request request, ActionListener<Response> listener) {
+        protected void doExecute(Task task,
+                                 Request request,
+                                 ActionListener<AcknowledgedResponse> listener) {
+
             client.admin().cluster().state(new ClusterStateRequest(), ActionListener.wrap(r -> {
                 IndexMetaData followIndexMetadata = r.getState().getMetaData().index(request.followIndex);
                 if (followIndexMetadata == null) {
@@ -140,7 +136,7 @@ void finalizeResponse() {
 
                                 if (error == null) {
                                     // include task ids?
-                                    listener.onResponse(new Response(true));
+                                    listener.onResponse(new AcknowledgedResponse(true));
                                 } else {
                                     // TODO: cancel all started tasks
                                     listener.onFailure(error);
diff --git a/x-pack/plugin/ccr/src/test/java/org/elasticsearch/xpack/ccr/CcrLicenseIT.java b/x-pack/plugin/ccr/src/test/java/org/elasticsearch/xpack/ccr/CcrLicenseIT.java
@@ -8,6 +8,7 @@
 
 import org.elasticsearch.ElasticsearchSecurityException;
 import org.elasticsearch.action.ActionListener;
+import org.elasticsearch.action.support.master.AcknowledgedResponse;
 import org.elasticsearch.common.unit.TimeValue;
 import org.elasticsearch.plugins.Plugin;
 import org.elasticsearch.test.ESSingleNodeTestCase;
@@ -36,9 +37,9 @@ public void testThatFollowingIndexIsUnavailableWithIncompatibleLicense() throws
         client().execute(
                 FollowIndexAction.INSTANCE,
                 followRequest,
-                new ActionListener<FollowIndexAction.Response>() {
+                new ActionListener<AcknowledgedResponse>() {
                     @Override
-                    public void onResponse(final FollowIndexAction.Response response) {
+                    public void onResponse(final AcknowledgedResponse response) {
                         fail();
                     }
 
