Move set copy from builder to constructor

Andrey Ershov · Andrey Ershov · commit 310d65a5b5ae · 2018-11-20T19:33:45.000+01:00
diff --git a/server/src/main/java/org/elasticsearch/cluster/coordination/CoordinationMetaData.java b/server/src/main/java/org/elasticsearch/cluster/coordination/CoordinationMetaData.java
@@ -86,7 +86,7 @@ public CoordinationMetaData(long term, VotingConfiguration lastCommittedConfigur
         this.term = term;
         this.lastCommittedConfiguration = lastCommittedConfiguration;
         this.lastAcceptedConfiguration = lastAcceptedConfiguration;
-        this.votingTombstones = votingTombstones;
+        this.votingTombstones = Collections.unmodifiableSet(new HashSet<>(votingTombstones));
     }
 
     public CoordinationMetaData(StreamInput in) throws IOException {
@@ -216,8 +216,7 @@ public Builder clearVotingTombstones() {
         }
 
         public CoordinationMetaData build() {
-            return new CoordinationMetaData(term, lastCommittedConfiguration, lastAcceptedConfiguration,
-                Collections.unmodifiableSet(new HashSet<>(votingTombstones)));
+            return new CoordinationMetaData(term, lastCommittedConfiguration, lastAcceptedConfiguration, votingTombstones);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ public CoordinationMetaData(long term, VotingConfiguration lastCommittedConfigur`
`86`	`86`	`this.term = term;`
`87`	`87`	`this.lastCommittedConfiguration = lastCommittedConfiguration;`
`88`	`88`	`this.lastAcceptedConfiguration = lastAcceptedConfiguration;`
`89`		`- this.votingTombstones = votingTombstones;`
	`89`	`+ this.votingTombstones = Collections.unmodifiableSet(new HashSet<>(votingTombstones));`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`public CoordinationMetaData(StreamInput in) throws IOException {`
`@@ -216,8 +216,7 @@ public Builder clearVotingTombstones() {`
`216`	`216`	`}`
`217`	`217`
`218`	`218`	`public CoordinationMetaData build() {`
`219`		`- return new CoordinationMetaData(term, lastCommittedConfiguration, lastAcceptedConfiguration,`
`220`		`- Collections.unmodifiableSet(new HashSet<>(votingTombstones)));`
	`219`	`+ return new CoordinationMetaData(term, lastCommittedConfiguration, lastAcceptedConfiguration, votingTombstones);`
`221`	`220`	`}`
`222`	`221`	`}`
`223`	`222`