Skip to content

Commit 1fe42c9

Browse files
committed
Fixes after adding UBI Docker support
The CertGenCliTests needed an update to ignore the UBI Docker distribution as well as the regular Docker distribution.
1 parent 1d43e76 commit 1fe42c9

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

qa/os/src/test/java/org/elasticsearch/packaging/test/CertGenCliTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public class CertGenCliTests extends PackagingTestCase {
5050
@Before
5151
public void filterDistros() {
5252
assumeTrue("only default distro", distribution.flavor == Distribution.Flavor.DEFAULT);
53-
assumeTrue("no docker", distribution.packaging != Distribution.Packaging.DOCKER);
53+
assumeFalse("no docker", distribution.isDocker());
5454
}
5555

5656
@BeforeClass

qa/os/src/test/java/org/elasticsearch/packaging/test/PackagingTestCase.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,7 @@ protected static void install() throws Exception {
216216
Packages.verifyPackageInstallation(installation, distribution, sh);
217217
break;
218218
case DOCKER:
219+
case DOCKER_UBI:
219220
installation = Docker.runContainer(distribution);
220221
Docker.verifyContainerInstallation(installation, distribution);
221222
break;
@@ -291,6 +292,7 @@ public Shell.Result runElasticsearchStartCommand(String password, boolean daemon
291292
case RPM:
292293
return Packages.runElasticsearchStartCommand(sh);
293294
case DOCKER:
295+
case DOCKER_UBI:
294296
// nothing, "installing" docker image is running it
295297
return Shell.NO_OP;
296298
default:
@@ -309,6 +311,7 @@ public void stopElasticsearch() throws Exception {
309311
Packages.stopElasticsearch(sh);
310312
break;
311313
case DOCKER:
314+
case DOCKER_UBI:
312315
// nothing, "installing" docker image is running it
313316
break;
314317
default:
@@ -328,6 +331,7 @@ public void awaitElasticsearchStartup(Shell.Result result) throws Exception {
328331
Packages.assertElasticsearchStarted(sh, installation);
329332
break;
330333
case DOCKER:
334+
case DOCKER_UBI:
331335
Docker.waitForElasticsearchToStart();
332336
break;
333337
default:

0 commit comments

Comments
 (0)